[jira] [Commented] (CALCITE-586) Serializing Signature.internalParameters can cause exceptions

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306071#comment-14306071 ] 

Vladimir Sitnikov commented on CALCITE-586:
-------------------------------------------

[~devth], can you please split  pull request into two separate ones?

[~julianhyde], do we need to remove annotation {{@JsonProperty("internalParameters") Map<String, Object> internalParameters}} as well?

{code:java}
    @JsonCreator
    public Signature(@JsonProperty("columns") List<ColumnMetaData> columns,
        @JsonProperty("sql") String sql,
        @JsonProperty("parameters") List<AvaticaParameter> parameters,
        @JsonProperty("internalParameters") Map<String, Object>
            internalParameters,
        @JsonProperty("cursorFactory") CursorFactory cursorFactory) {
      this.columns = columns;
      this.sql = sql;
      this.parameters = parameters;
      this.internalParameters = internalParameters;
{code}

> Serializing Signature.internalParameters can cause exceptions
> -------------------------------------------------------------
>
>                 Key: CALCITE-586
>                 URL: https://issues.apache.org/jira/browse/CALCITE-586
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Trevor Hartman
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: next
>
>
> Observed exceptions:
> {code}
> java.lang.AssertionError: null
> at org.apache.calcite.rel.type.RelDataTypeImpl.getFieldList(RelDataTypeImpl.java:138) ~[calcite-core-1.0.0-incubating-SNAPSHOT.jar:1.0.0-incubating-SNAPSHOT]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_25]
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_25]
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_25]
> at java.lang.reflect.Method.invoke(Method.java:483) ~[na:1.8.0_25]
> at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:466) ~[jackson-databind-2.4.2.jar:2.4.2]
> {code}
> And in https://github.com/devth/calcite-map-demo:
> {code}
> java.lang.RuntimeException: com.fasterxml.jackson.databind.JsonMappingException: No serializer found for class org.apache.calcite.sql.type.SqlTypeExplicitPrecedenceList and no properties discovered to create BeanSerializer (to avoid exception, disable SerializationConfig.SerializationFeature.FAIL_ON_EMPTY_BEANS) ) (through reference chain: org.apache.calcite.avatica.remote.ResultSetResponse["signature"]->org.apache.calcite.avatica.Signature["internalParameters"]->java.util.LinkedHashMap["v0stashed"]->com.google.common.collect.RegularImmutableList[0]->org.apache.calcite.rex.RexCall["operands"]->com.google.common.collect.RegularImmutableList[0]->org.apache.calcite.rex.RexInputRef["type"]->org.apache.calcite.sql.type.MapSqlType["keyType"]->org.apache.calcite.sql.type.BasicSqlType["precedenceList"])
>         at org.apache.calcite.avatica.remote.JsonHandler.handle(JsonHandler.java:61) ~[calcite-avatica-1.0.0-incubating.jar:1.0.0-incubating]
>         at org.apache.calcite.avatica.remote.JsonHandler.apply(JsonHandler.java:46) ~[calcite-avatica-1.0.0-incubating.jar:1.0.0-incubating]
>         at org.apache.calcite.avatica.server.AvaticaHandler.handle(AvaticaHandler.java:47) ~[calcite-avatica-server-1.0.0-incubating.jar:1.0.0-incubating]
> {code}
> Pull request:
> https://github.com/apache/incubator-calcite/pull/48



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)