You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/22 21:15:08 UTC
[GitHub] [arrow] kou opened a new pull request, #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
kou opened a new pull request, #35286:
URL: https://github.com/apache/arrow/pull/35286
### Rationale for this change
`GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive.
`GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive.
### What changes are included in this PR?
Add missing parent metadata references to sub metadata.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1522418638
> (At lease we found a parquet bug in glibc)
Correct: "in the C GLib bindings" not "glibc" :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35286:
URL: https://github.com/apache/arrow/pull/35286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1518948137
I don't know...
It may be related or may not be related...
This problem related any memory resources. For example, any GitHub Actions macOS runner's change may be related.
FYI: We can reproduce this problem by running GC explicitly by `GC.start`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1521624093
(At lease we found a parquet bug in glibc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1519133902
Benchmark runs are scheduled for baseline = 8601aac9ee2c35eb38d70f2fa90f8cb82c4dafc5 and contender = f4bd43d28eae13a48d5225ea44a16646ef093155. f4bd43d28eae13a48d5225ea44a16646ef093155 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a8dbe4a7de4f4fb1aa9d119cc32c3693...7b126dc7e5114c0f863233c98c90efa3/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dd9cbf0f2f00444a81686229ef08f854...ae5cd72d2c754fb3ad59dcebe261ec1a/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/671df5557fca4a11bc4954b01ef8c4e4...4a27255bc87b4187992365743224ec34/)
[Finished :arrow_down:0.36% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e75ed870da9144af80b994e19388dd5e...c1e220877ff04ea5a26d29526d31683c/)
Buildkite builds:
[Finished] [`f4bd43d2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2771)
[Failed] [`f4bd43d2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2805)
[Finished] [`f4bd43d2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2769)
[Finished] [`f4bd43d2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2796)
[Finished] [`8601aac9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2770)
[Failed] [`8601aac9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2804)
[Finished] [`8601aac9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2768)
[Finished] [`8601aac9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2795)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1518919051
(Just curious, why did my patch trigger that GC problem?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1518948149
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35286: GH-35266: [GLib][Parquet] Fix a GC bug that parent metadata reference is missing in sub metadata
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35286:
URL: https://github.com/apache/arrow/pull/35286#issuecomment-1518817322
* Closes: #35266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org