You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2022/06/20 16:28:00 UTC

[jira] [Resolved] (HBASE-27099) In the HFileBlock class, the log printing fspread/fsread cost time unit should be milliseconds

     [ https://issues.apache.org/jira/browse/HBASE-27099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-27099.
-------------------------------
    Fix Version/s: 2.5.0
                   2.4.13
                   3.0.0-alpha-4
     Hadoop Flags: Reviewed
       Resolution: Fixed

Pushed to branch-2.4+.

Thanks [~xiaozhang] for contributing!

> In the HFileBlock class, the log printing fspread/fsread cost time unit should be milliseconds
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-27099
>                 URL: https://issues.apache.org/jira/browse/HBASE-27099
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 3.0.0-alpha-2, 2.3.7, 2.4.12, 2.5.1
>            Reporter: Xiao Zhang
>            Assignee: Xiao Zhang
>            Priority: Minor
>             Fix For: 2.5.0, 2.4.13, 3.0.0-alpha-4
>
>
> In the HFileBlock class
>  
> {code:java}
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset, long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, boolean updateMetrics, boolean intoHeap) throws IOException {
>   ...
>   long startTime = EnvironmentEdgeManager.currentTime();
>   ...
>   long duration = EnvironmentEdgeManager.currentTime() - startTime;
>   if (updateMetrics) {
>     HFile.updateReadLatency(duration, pread);
>   }
>   ...
>   LOG.trace("Read {} in {} ns", hFileBlock, duration);
>   ...
> }{code}
> But Environment EdgeManager.currentTime returns milliseconds.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)