You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/24 05:41:41 UTC
[GitHub] [skywalking] osiriswd opened a new pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
osiriswd opened a new pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
Dubbo Version: 2.7.5
Skywalking Version: 8.3.0
My Java app ran into an endless FullGC state some days before. After some analysis, I found this.
When Dubbo RPC Chain acts like: A-->dubbo://B-->dubbo://C, and in some situation server C slow down or suddenly crush, Dubbo-thread(Provider) on Server B may triggers an 'Consumer is shutting down' Exception, org.apache.dubbo.rpc.AsyncRpcResult.getAppResponse won't get any result(dubbo code notes: '// This should not happen in normal request process;').
Then result.getException in afterMethod throws exception in Skywalking java agent as below(won't log into span.log):
> ERROR 2021-01-27 15:06:19:290 Dubbo-thread-388 InstMethodsInter : class[class org.apache.dubbo.monitor.support.MonitorFilter] after method[invoke] intercept failure
> org.apache.dubbo.rpc.RpcException: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Consumer is shutting down and this call is going to be stopped without receiving any result, usually this is called by a slow provider instance or bad service implementation.
> at org.apache.dubbo.rpc.AsyncRpcResult.getAppResponse(AsyncRpcResult.java:148)
> at org.apache.dubbo.rpc.AsyncRpcResult.getException(AsyncRpcResult.java:107)
> at org.apache.skywalking.apm.plugin.asf.dubbo.DubboInterceptor.afterMethod(DubboInterceptor.java:110)
> at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:97)
> at org.apache.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java)
> at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
> at org.apache.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:49)
> at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
StopSpan() won't work, TraceSegment will be kept by ThreadLocal when dubbo runs in threadpool mode.
While this thread creating new entryspans later, the old TraceSegment will be added into refs.(memory leak)
This is a JVM heapdump after the memory leak happened for several days(the thread is holding 768332 spans):
I thinks maybe there are some 'unnormal' RpcExceptions which can't be obtained by result.getException(). Perhaps we could catch them when calling it from afterMethod.
Built an new dubbo-2.7.x-plugin on my machine and it looks good now.
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.72%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.10% -20.73%
+ Complexity 3970 2637 -1333
=============================================
Files 985 1033 +48
Lines 24397 25112 +715
Branches 2401 2460 +59
=============================================
- Hits 13864 9066 -4798
- Misses 9305 15357 +6052
+ Partials 1228 689 -539
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `23.61%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 33.21% -23.62%
+ Complexity 3970 2418 -1552
=============================================
Files 985 987 +2
Lines 24397 24229 -168
Branches 2401 2368 -33
=============================================
- Hits 13864 8047 -5817
- Misses 9305 15564 +6259
+ Partials 1228 618 -610
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `18.85%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 37.97% -18.86%
+ Complexity 3970 2785 -1185
=============================================
Files 985 1004 +19
Lines 24397 24803 +406
Branches 2401 2431 +30
=============================================
- Hits 13864 9419 -4445
- Misses 9305 14646 +5341
+ Partials 1228 738 -490
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `16.60%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 40.22% -16.61%
+ Complexity 3970 2916 -1054
=============================================
Files 985 1004 +19
Lines 24397 24806 +409
Branches 2401 2431 +30
=============================================
- Hits 13864 9977 -3887
- Misses 9305 14056 +4751
+ Partials 1228 773 -455
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 194 -791
Lines 24397 4654 -19743
Branches 2401 544 -1857
============================================
- Hits 13864 0 -13864
+ Misses 9305 4654 -4651
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `8.12%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 48.69% -8.13%
+ Complexity 3970 3586 -384
============================================
Files 985 1033 +48
Lines 24397 25169 +772
Branches 2401 2462 +61
============================================
- Hits 13864 12257 -1607
- Misses 9305 11884 +2579
+ Partials 1228 1028 -200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [205 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `15.94%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 40.88% -15.95%
+ Complexity 3970 2960 -1010
=============================================
Files 985 1004 +19
Lines 24397 24806 +409
Branches 2401 2431 +30
=============================================
- Hits 13864 10142 -3722
- Misses 9305 13876 +4571
+ Partials 1228 788 -440
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [302 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.54%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 49.27% -7.55%
+ Complexity 3970 3611 -359
============================================
Files 985 1033 +48
Lines 24397 25169 +772
Branches 2401 2462 +61
============================================
- Hits 13864 12403 -1461
- Misses 9305 11740 +2435
+ Partials 1228 1026 -202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [198 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.01%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.81% -20.02%
+ Complexity 3970 2677 -1293
=============================================
Files 985 1033 +48
Lines 24397 25131 +734
Branches 2401 2461 +60
=============================================
- Hits 13864 9252 -4612
- Misses 9305 15181 +5876
+ Partials 1228 698 -530
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `16.91%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 39.91% -16.92%
+ Complexity 3970 2896 -1074
=============================================
Files 985 1004 +19
Lines 24397 24806 +409
Branches 2401 2431 +30
=============================================
- Hits 13864 9901 -3963
- Misses 9305 14129 +4824
+ Partials 1228 776 -452
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [311 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 198 -787
Lines 24397 4702 -19695
Branches 2401 548 -1853
============================================
- Hits 13864 0 -13864
+ Misses 9305 4702 -4603
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [988 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.57%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 49.25% -7.58%
+ Complexity 3970 3609 -361
============================================
Files 985 1033 +48
Lines 24397 25169 +772
Branches 2401 2462 +61
============================================
- Hits 13864 12397 -1467
- Misses 9305 11745 +2440
+ Partials 1228 1027 -201
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [199 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.12%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.70% -4.13%
+ Complexity 3970 3883 -87
============================================
Files 985 1012 +27
Lines 24397 25015 +618
Branches 2401 2450 +49
============================================
- Hits 13864 13183 -681
- Misses 9305 10679 +1374
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [128 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `19.88%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.94% -19.89%
+ Complexity 3970 2684 -1286
=============================================
Files 985 1033 +48
Lines 24397 25131 +734
Branches 2401 2461 +60
=============================================
- Hits 13864 9284 -4580
- Misses 9305 15145 +5840
+ Partials 1228 702 -526
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `8.99%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 47.82% -9.00%
+ Complexity 3970 3549 -421
============================================
Files 985 1033 +48
Lines 24397 25169 +772
Branches 2401 2462 +61
============================================
- Hits 13864 12038 -1826
- Misses 9305 12111 +2806
+ Partials 1228 1020 -208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [214 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.01%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.81% -20.02%
+ Complexity 3970 2677 -1293
=============================================
Files 985 1033 +48
Lines 24397 25131 +734
Branches 2401 2461 +60
=============================================
- Hits 13864 9251 -4613
- Misses 9305 15181 +5876
+ Partials 1228 699 -529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `23.78%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 33.04% -23.79%
+ Complexity 3970 2399 -1571
=============================================
Files 985 1013 +28
Lines 24397 24593 +196
Branches 2401 2407 +6
=============================================
- Hits 13864 8126 -5738
- Misses 9305 15865 +6560
+ Partials 1228 602 -626
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [429 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 198 -787
Lines 24397 4702 -19695
Branches 2401 548 -1853
============================================
- Hits 13864 0 -13864
+ Misses 9305 4702 -4603
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [988 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.86%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.95% -20.87%
+ Complexity 3970 2586 -1384
=============================================
Files 985 987 +2
Lines 24397 24237 -160
Branches 2401 2369 -32
=============================================
- Hits 13864 8715 -5149
- Misses 9305 14829 +5524
+ Partials 1228 693 -535
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [367 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.20%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.61% -4.21%
+ Complexity 3970 3883 -87
============================================
Files 985 1013 +28
Lines 24397 25054 +657
Branches 2401 2451 +50
============================================
- Hits 13864 13183 -681
- Misses 9305 10718 +1413
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [129 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `7.53%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 49.29% -7.54%
+ Complexity 3970 3614 -356
============================================
Files 985 1033 +48
Lines 24397 25169 +772
Branches 2401 2462 +61
============================================
- Hits 13864 12406 -1458
- Misses 9305 11740 +2435
+ Partials 1228 1023 -205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [199 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.13%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.68% -20.14%
+ Complexity 3970 2667 -1303
=============================================
Files 985 1033 +48
Lines 24397 25131 +734
Branches 2401 2461 +60
=============================================
- Hits 13864 9220 -4644
- Misses 9305 15209 +5904
+ Partials 1228 702 -526
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [388 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.89%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.93% -20.90%
+ Complexity 3970 2630 -1340
=============================================
Files 985 1030 +45
Lines 24397 25097 +700
Branches 2401 2460 +59
=============================================
- Hits 13864 9018 -4846
- Misses 9305 15392 +6087
+ Partials 1228 687 -541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.15%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.66% -4.16%
+ Complexity 3970 3882 -88
============================================
Files 985 1012 +27
Lines 24397 25015 +618
Branches 2401 2450 +49
============================================
- Hits 13864 13175 -689
- Misses 9305 10687 +1382
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [129 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `18.84%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 37.97% -18.85%
+ Complexity 3970 2786 -1184
=============================================
Files 985 1004 +19
Lines 24397 24803 +406
Branches 2401 2431 +30
=============================================
- Hits 13864 9420 -4444
- Misses 9305 14646 +5341
+ Partials 1228 737 -491
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `15.45%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 41.36% -15.46%
+ Complexity 3970 3004 -966
=============================================
Files 985 1012 +27
Lines 24397 24986 +589
Branches 2401 2450 +49
=============================================
- Hits 13864 10336 -3528
- Misses 9305 13843 +4538
+ Partials 1228 807 -421
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [291 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.38%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.44% -4.39%
+ Complexity 3970 3864 -106
============================================
Files 985 1012 +27
Lines 24397 25015 +618
Branches 2401 2450 +49
============================================
- Hits 13864 13119 -745
- Misses 9305 10743 +1438
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [128 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `26.82%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 29.99% -26.83%
+ Complexity 3970 2223 -1747
=============================================
Files 985 1012 +27
Lines 24397 24554 +157
Branches 2401 2403 +2
=============================================
- Hits 13864 7366 -6498
- Misses 9305 16642 +7337
+ Partials 1228 546 -682
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [457 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `21.07%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.74% -21.08%
+ Complexity 3970 2578 -1392
=============================================
Files 985 987 +2
Lines 24397 24237 -160
Branches 2401 2369 -32
=============================================
- Hits 13864 8664 -5200
- Misses 9305 14889 +5584
+ Partials 1228 684 -544
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `13.49%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 43.32% -13.50%
+ Complexity 3970 3106 -864
=============================================
Files 985 1012 +27
Lines 24397 25005 +608
Branches 2401 2450 +49
=============================================
- Hits 13864 10834 -3030
- Misses 9305 13312 +4007
+ Partials 1228 859 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [269 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `21.06%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.76% -21.07%
+ Complexity 3970 2580 -1390
=============================================
Files 985 987 +2
Lines 24397 24237 -160
Branches 2401 2369 -32
=============================================
- Hits 13864 8668 -5196
- Misses 9305 14886 +5581
+ Partials 1228 683 -545
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `10.75%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 46.07% -10.76%
+ Complexity 3970 3454 -516
=============================================
Files 985 1033 +48
Lines 24397 25133 +736
Branches 2401 2461 +60
=============================================
- Hits 13864 11580 -2284
- Misses 9305 12566 +3261
+ Partials 1228 987 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [232 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.71%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 36.10% -20.72%
+ Complexity 3970 2637 -1333
=============================================
Files 985 1032 +47
Lines 24397 25108 +711
Branches 2401 2460 +59
=============================================
- Hits 13864 9066 -4798
- Misses 9305 15353 +6048
+ Partials 1228 689 -539
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [396 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 173 -812
Lines 24397 4235 -20162
Branches 2401 486 -1915
============================================
- Hits 13864 0 -13864
+ Misses 9305 4235 -5070
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [963 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.28%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.54% -4.29%
+ Complexity 3970 3873 -97
============================================
Files 985 1012 +27
Lines 24397 25015 +618
Branches 2401 2450 +49
============================================
- Hits 13864 13143 -721
- Misses 9305 10719 +1414
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `20.90%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.91% -20.91%
+ Complexity 3970 2630 -1340
=============================================
Files 985 1032 +47
Lines 24397 25108 +711
Branches 2401 2460 +59
=============================================
- Hits 13864 9018 -4846
- Misses 9305 15403 +6098
+ Partials 1228 687 -541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `21.06%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 35.75% -21.07%
+ Complexity 3970 2580 -1390
=============================================
Files 985 987 +2
Lines 24397 24237 -160
Branches 2401 2369 -32
=============================================
- Hits 13864 8667 -5197
- Misses 9305 14887 +5582
+ Partials 1228 683 -545
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 165 -820
Lines 24397 4103 -20294
Branches 2401 475 -1926
============================================
- Hits 13864 0 -13864
+ Misses 9305 4103 -5202
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [961 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `11.16%`.
> The diff coverage is `36.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 45.66% -11.17%
+ Complexity 3970 3425 -545
=============================================
Files 985 1033 +48
Lines 24397 25133 +736
Branches 2401 2461 +60
=============================================
- Hits 13864 11476 -2388
- Misses 9305 12682 +3377
+ Partials 1228 975 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `40.35% <40.35%> (ø)` | `5.00 <5.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `41.37% <41.37%> (ø)` | `6.00 <6.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| ... and [255 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (e21e4dc) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 194 -791
Lines 24397 4654 -19743
Branches 2401 544 -1857
============================================
- Hits 13864 0 -13864
+ Misses 9305 4654 -4651
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `5.66%`.
> The diff coverage is `45.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 51.15% -5.67%
+ Complexity 3970 3883 -87
============================================
Files 985 1790 +805
Lines 24397 38237 +13840
Branches 2401 4207 +1806
============================================
+ Hits 13864 19561 +5697
- Misses 9305 17674 +8369
+ Partials 1228 1002 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `55.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...flux/v5/webclient/WebFluxWebClientInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvc3ByaW5nLXdlYmZsdXgtNS54LXdlYmNsaWVudC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvd2ViZmx1eC92NS93ZWJjbGllbnQvV2ViRmx1eFdlYkNsaWVudEludGVyY2VwdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `11.76% <11.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...walking/apm/plugin/asf/dubbo/DubboInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZHViYm8tMi43LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vYXNmL2R1YmJvL0R1YmJvSW50ZXJjZXB0b3IuamF2YQ==) | `73.41% <25.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `4.20%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 52.61% -4.21%
+ Complexity 3970 3883 -87
============================================
Files 985 1013 +28
Lines 24397 25054 +657
Branches 2401 2451 +50
============================================
- Hits 13864 13183 -681
- Misses 9305 10718 +1413
+ Partials 1228 1153 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [129 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `56.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
- Coverage 56.82% 0.00% -56.83%
============================================
Files 985 171 -814
Lines 24397 4223 -20174
Branches 2401 486 -1915
============================================
- Hits 13864 0 -13864
+ Misses 9305 4223 -5082
+ Partials 1228 0 -1228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [961 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6432: Fix apm-dubbo-2.7.x-plugin memory leak due to some Dubbo RpcExceptions.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6432:
URL: https://github.com/apache/skywalking/pull/6432#issuecomment-784799900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=h1) Report
> Merging [#6432](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=desc) (486ebda) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `15.33%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6432 +/- ##
=============================================
- Coverage 56.82% 41.49% -15.34%
+ Complexity 3970 3004 -966
=============================================
Files 985 1007 +22
Lines 24397 24910 +513
Branches 2401 2442 +41
=============================================
- Hits 13864 10336 -3528
- Misses 9305 13767 +4462
+ Partials 1228 807 -421
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6432/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=footer). Last update [665a07c...486ebda](https://codecov.io/gh/apache/skywalking/pull/6432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org