[GitHub] [kafka] cmccabe commented on a diff in pull request #12195: MINOR: implement BrokerRegistrationChangeRecord

[GitBox <gi...@apache.org>]

cmccabe commented on code in PR #12195:
URL: https://github.com/apache/kafka/pull/12195#discussion_r887035686


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -153,7 +153,10 @@ public enum MetadataVersion {
     IBP_3_2_IV0(4, "3.2", "IV0", false),
 
     // Support for metadata.version feature flag (KIP-778)
-    IBP_3_3_IV0(5, "3.3", "IV0", false);
+    IBP_3_3_IV0(5, "3.3", "IV0", false),
+
+    // In KRaft mode, use BrokerRegistrationChangeRecord instead of UnfenceBrokerRecord and FenceBrokerRecord.
+    IBP_3_3_IV1(6, "3.3", "IV1", false);

Review Comment:
   I was originally going to mark this "false" because although the metadata records changed, no new concepts were added, so the older version could accurately represent what was going on. However, that's kind of tricky reasoning, so probably better to just set to "true".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org