You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/01 12:19:04 UTC

[kudu-CR] WIP: Add a way to get the physical time component of a hybrid timestamp 

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5304

Change subject: WIP: Add a way to get the physical time component of a hybrid timestamp
......................................................................

WIP: Add a way to get the physical time component of a hybrid timestamp

This adds a new method to Clock:
MonoTime PhysicalComponentOfTimestamp(Timestamp a) const

This allows to obtain a MonoTime representing the physical timestamp
of a hybrid timestamp. For instance, this can be used to calculate
how far back in the past safe time hybrid timestamp is.

WIP as it's still missing a small unit test.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
3 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5304/8/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

PS8, Line 286: MonoDelta delta = clock_->GetPhysicalComponentDifference(now2, now1);
Didn't notice this in my first review pass, but it's better late than never :)

Consider adding a test which verifies all is well for negative deltas as well.


PS8, Line 287: ASSERT_EQ
nit: ASSERT_EQ() the expected value for the ASSERT_EQ() comes as the first parameter


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#9).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 31 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/9
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#4).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 27 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

Line 288:   ASSERT_LT(delta.ToMilliseconds(), 100);
> seems potentially flaky. Maybe just construct the timestamps manually?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Reviewed-on: http://gerrit.cloudera.org:8080/5304
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 31 insertions(+), 7 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5304/8/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

PS8, Line 286: MonoDelta delta = clock_->GetPhysicalComponentDifference(now2, now1);
> Didn't notice this in my first review pass, but it's better late than never
Done


PS8, Line 287: ASSERT_EQ
> nit: ASSERT_EQ() the expected value for the ASSERT_EQ() comes as the first 
man I always get that wrong. Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5304/3/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

PS3, Line 288: 
> could you use operator- here instead:
this is a old revision


http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock.h
File src/kudu/server/hybrid_clock.h:

PS4, Line 65: GetPhysicalComponentDifference
> nit: could you add a comment that the difference is about (a - b), not (b -
I added that comment on the Clock class header. Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Add a way to get the physical time component of a hybrid timestamp

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#2).

Change subject: Add a way to get the physical time component of a hybrid timestamp
......................................................................

Add a way to get the physical time component of a hybrid timestamp

This adds a new method to Clock:
MonoTime PhysicalComponentOfTimestamp(Timestamp a) const

This allows to obtain a MonoTime representing the physical timestamp
of a hybrid timestamp. For instance, this can be used to calculate
how far back in the past safe time hybrid timestamp is.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 32 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#5).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 26 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5304/3/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

PS3, Line 288: delta.ToMilliseconds(), 100);
could you use operator- here instead:

(now2_mt - now1_mt).ToSeconds()

?


http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock.h
File src/kudu/server/hybrid_clock.h:

PS4, Line 65: GetPhysicalComponentDifference
nit: could you add a comment that the difference is about (a - b), not (b - a)?

Besides, if it makes sense to you, may be it's worth renaming a --> lhs, b --> rhs?


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#7).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 30 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock-test.cc
File src/kudu/server/hybrid_clock-test.cc:

Line 288:   ASSERT_LT(delta.ToMilliseconds(), 100);
seems potentially flaky. Maybe just construct the timestamps manually?


-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#8).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 29 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/8
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add a way to get the physical time component of a hybrid timestamp

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#3).

Change subject: Add a way to get the physical time component of a hybrid timestamp
......................................................................

Add a way to get the physical time component of a hybrid timestamp

This adds a new method to Clock:
MonoTime PhysicalComponentOfTimestamp(Timestamp a) const

This allows to obtain a MonoTime representing the physical timestamp
of a hybrid timestamp. For instance, this can be used to calculate
how far back in the past safe time hybrid timestamp is.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 32 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5304

to look at the new patch set (#6).

Change subject: Allow to get a MonoDelta from two Timestamps
......................................................................

Allow to get a MonoDelta from two Timestamps

This adds a new method to Clock:
MonoDelta GetPhysicalComponentDifference(Timestamp a, Timestamp b) const

The MonoDelta represents the difference between the physical
components of 'a' and 'b'.

Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
---
M src/kudu/server/clock.h
M src/kudu/server/hybrid_clock-test.cc
M src/kudu/server/hybrid_clock.cc
M src/kudu/server/hybrid_clock.h
4 files changed, 29 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5304/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>