You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/11 12:39:32 UTC

[GitHub] [flink] dianfu commented on a change in pull request #11055: [FLINK-15990][table] Remove register source and sink in ConnectTableDescriptor

dianfu commented on a change in pull request #11055: [FLINK-15990][table] Remove register source and sink in ConnectTableDescriptor
URL: https://github.com/apache/flink/pull/11055#discussion_r377606508
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_descriptor.py
 ##########
 @@ -963,7 +963,7 @@ def test_register_table_source_and_register_table_sink(self):
                           .field("a", DataTypes.INT())
                           .field("b", DataTypes.STRING())
                           .field("c", DataTypes.STRING()))\
-             .register_table_source("source")
+             .create_temporary_table("source")
 
 Review comment:
   What about removing test_register_table_source_and_register_table_sink and renaming test_register_table_source_and_sink to test_register_temporary_table?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services