[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6885: Updating QueryRunner to return object of report summary

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6885:
URL: https://github.com/apache/incubator-pinot/pull/6885#discussion_r627850674



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java
##########
@@ -317,15 +319,19 @@ public static void singleThreadedQueryRunner(PerfBenchmarkDriverConf conf, List<
     }
 
     long timePassed = System.currentTimeMillis() - startTime;
+
+    QuerySummary querySummary = new QuerySummary(timePassed, numQueriesExecuted, numExceptions, totalBrokerTime,
+        totalClientTime, statisticsList);
     LOGGER.info("--------------------------------------------------------------------------------");
     LOGGER.info("FINAL REPORT:");
     LOGGER.info("Time Passed: {}ms, Queries Executed: {}, Exceptions: {}, Average QPS: {}, Average Broker Time: {}ms, "
-            + "Average Client Time: {}ms.", timePassed, numQueriesExecuted, numExceptions,
-        numQueriesExecuted / ((double) timePassed / MILLIS_PER_SECOND), totalBrokerTime / (double) numQueriesExecuted,
-        totalClientTime / (double) numQueriesExecuted);
+            + "Average Client Time: {}ms.", querySummary.getTimePassed(), querySummary.getNumQueriesExecuted(),

Review comment:
       Override `QuerySummary.toString()` and use it here? Same for other reports




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org