You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by zs...@apache.org on 2008/12/31 00:00:47 UTC
svn commit: r730266 - in /hadoop/hive/trunk: CHANGES.txt
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java
ql/src/test/results/clientpositive/cast1.q.out
Author: zshao
Date: Tue Dec 30 15:00:47 2008
New Revision: 730266
URL: http://svn.apache.org/viewvc?rev=730266&view=rev
Log:
HIVE-197. Fixed UDFToBoolean. (zshao)
Modified:
hadoop/hive/trunk/CHANGES.txt
hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java
hadoop/hive/trunk/ql/src/test/results/clientpositive/cast1.q.out
Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=730266&r1=730265&r2=730266&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Tue Dec 30 15:00:47 2008
@@ -66,6 +66,8 @@
BUG FIXES
+ HIVE-197. Fixed UDFToBoolean. (zshao)
+
HIVE-171. Fixed select star with cluster by, distribute by and sort by.
(zshao)
Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java?rev=730266&r1=730265&r2=730266&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java Tue Dec 30 15:00:47 2008
@@ -40,7 +40,7 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.byteValue() == 0);
+ return Boolean.valueOf(i.byteValue() != 0);
}
}
@@ -54,7 +54,7 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.shortValue() == 0);
+ return Boolean.valueOf(i.shortValue() != 0);
}
}
@@ -68,7 +68,7 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.intValue() == 0);
+ return Boolean.valueOf(i.intValue() != 0);
}
}
@@ -82,7 +82,7 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.longValue() == 0);
+ return Boolean.valueOf(i.longValue() != 0);
}
}
@@ -96,7 +96,7 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.floatValue() == 0);
+ return Boolean.valueOf(i.floatValue() != 0);
}
}
@@ -110,21 +110,8 @@
if (i == null) {
return null;
} else {
- return Boolean.valueOf(i.doubleValue() == 0);
+ return Boolean.valueOf(i.doubleValue() != 0);
}
}
- /**
- * Convert from a string to boolean. This is called for CAST(... AS BOOLEAN)
- *
- * @param i The string value to convert
- * @return Boolean
- */
- public Boolean evaluate(String i) {
- if (i == null) {
- return null;
- } else {
- return Boolean.valueOf(i.length() == 0);
- }
- }
}
Modified: hadoop/hive/trunk/ql/src/test/results/clientpositive/cast1.q.out
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/results/clientpositive/cast1.q.out?rev=730266&r1=730265&r2=730266&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/test/results/clientpositive/cast1.q.out (original)
+++ hadoop/hive/trunk/ql/src/test/results/clientpositive/cast1.q.out Tue Dec 30 15:00:47 2008
@@ -69,4 +69,4 @@
name: dest1
-5 5.0 5.0 5.0 5 FALSE 1
+5 5.0 5.0 5.0 5 TRUE 1