[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16676: [fix][broker] Retry to delete the namespace if new topics created during the namespace deletion

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #16676:
URL: https://github.com/apache/pulsar/pull/16676#discussion_r924219678


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -346,8 +346,15 @@ protected void internalDeleteNamespace(AsyncResponse asyncResponse, boolean auth
             asyncResponse.resume(Response.noContent().build());
         })
         .exceptionally(ex -> {
-            log.error("[{}] Failed to remove namespace {}", clientAppId(), namespaceName, ex.getCause());
-            resumeAsyncResponseExceptionally(asyncResponse, ex);
+            Throwable cause = FutureUtil.unwrapCompletionException(ex);
+            log.error("[{}] Failed to remove namespace {}", clientAppId(), namespaceName, cause);
+            if (cause instanceof PulsarAdminException.ConflictException) {
+                log.info("[{}] There are new topics created during the namespace deletion, "
+                        + "retry to delete the namespace again.", namespaceName);
+                internalDeleteNamespace(asyncResponse, authoritative);

Review Comment:
   Without force deletion, the next retry will return an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org