You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2020/01/31 18:34:50 UTC

[incubator-superset] branch john-bodley--fix-is-adhoc-metric created (now 4972849)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley--fix-is-adhoc-metric
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at 4972849  [fix] Ensure that is_adhoc_metric returns a boolean

This branch includes the following new commits:

     new 4972849  [fix] Ensure that is_adhoc_metric returns a boolean

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-superset] 01/01: [fix] Ensure that is_adhoc_metric returns a boolean

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--fix-is-adhoc-metric
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 4972849327c188b99f28a40f9405e24ee3895289
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri Jan 31 10:34:39 2020 -0800

    [fix] Ensure that is_adhoc_metric returns a boolean
---
 superset/utils/core.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/utils/core.py b/superset/utils/core.py
index ce55814..b927742 100644
--- a/superset/utils/core.py
+++ b/superset/utils/core.py
@@ -941,7 +941,7 @@ def get_example_database():
 
 
 def is_adhoc_metric(metric) -> bool:
-    return (
+    return bool(
         isinstance(metric, dict)
         and (
             (