You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2018/11/20 13:37:04 UTC
[GitHub] brooklyn-ui pull request #111: fix json editor state issues
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-ui/pull/111
fix json editor state issues
if you are editting json in the spec editor, every valid change does a model update and changes the `$viewValue` to the stringified output `{"key":"vallue"}` which is unhelpful when you're trying to get useful spaces
this prevents the update if the `$viewValue` gives the same value, and if making a new value it nicely formats it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-ui fix-json
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 8a82585bcf4a402f6b935aca351880dd65819ead
Author: Alex Heneveld <al...@...>
Date: 2018-11-20T13:35:07Z
fix json editor state
----
---
[GitHub] brooklyn-ui issue #111: fix json editor state issues
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/111
LGTM; merging.
---
[GitHub] brooklyn-ui pull request #111: fix json editor state issues
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/111
---