You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/16 01:37:01 UTC

[GitHub] [spark] wangshengjie123 commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy

wangshengjie123 commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1216046907

   > 
   
   Thanks @JoshRosen  for review this pr. 
   
   We have the the situation in our production environment, we set `spark.shuffle.service.index.cache.size` to 256m, we found it need about 2 day to reach the cache limit size and old cache those apps already finished still in old gen memory.  
   
   As you suggested, we adjusted NM memory size to solve the memory problem, also we could adjust cache limit size.
   
   But sometimes we need to face the face business growth and adjust NM memory is an expensive operation, so this pr just a optimization for cacheļ¼Œ i am not sure this is a common case but useful for our situation. 
   
   Thanks again @JoshRosen  for your reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org