You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2014/04/28 23:42:54 UTC
svn commit: r1590814 - in
/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner:
./ visitors/
Author: hboutemy
Date: Mon Apr 28 21:42:54 2014
New Revision: 1590814
URL: http://svn.apache.org/r1590814
Log:
removed too verbose debug log items
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/DefaultMojoAnnotationsScanner.java
maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoAnnotationVisitor.java
maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoClassVisitor.java
maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoFieldVisitor.java
Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/DefaultMojoAnnotationsScanner.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/DefaultMojoAnnotationsScanner.java?rev=1590814&r1=1590813&r2=1590814&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/DefaultMojoAnnotationsScanner.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/DefaultMojoAnnotationsScanner.java Mon Apr 28 21:42:54 2014
@@ -145,9 +145,12 @@ public class DefaultMojoAnnotationsScann
}
if ( isStoreClass( mojoClassVisitor.getMojoAnnotatedClass() ) != null )
{
- getLogger().debug(
- "found MojoAnnotatedClass:" + mojoClassVisitor.getMojoAnnotatedClass().getClassName() + ":"
- + mojoClassVisitor.getMojoAnnotatedClass() );
+ if ( getLogger().isDebugEnabled() )
+ {
+ getLogger().debug( "found MojoAnnotatedClass:"
+ + mojoClassVisitor.getMojoAnnotatedClass().getClassName() + ":"
+ + mojoClassVisitor.getMojoAnnotatedClass() );
+ }
mojoClassVisitor.getMojoAnnotatedClass().setArtifact( artifact );
mojoAnnotatedClasses.put( mojoClassVisitor.getMojoAnnotatedClass().getClassName(),
mojoClassVisitor.getMojoAnnotatedClass() );
@@ -215,8 +218,11 @@ public class DefaultMojoAnnotationsScann
if ( isStoreClass( mojoAnnotatedClass ) != null )
{
- getLogger().debug( "found MojoAnnotatedClass:" + mojoAnnotatedClass.getClassName() + ":"
- + mojoAnnotatedClass );
+ if ( getLogger().isDebugEnabled() )
+ {
+ getLogger().debug( "found MojoAnnotatedClass:" + mojoAnnotatedClass.getClassName() + ":"
+ + mojoAnnotatedClass );
+ }
mojoAnnotatedClass.setArtifact( artifact );
mojoAnnotatedClasses.put( mojoAnnotatedClass.getClassName(), mojoAnnotatedClass );
}
Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoAnnotationVisitor.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoAnnotationVisitor.java?rev=1590814&r1=1590813&r2=1590814&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoAnnotationVisitor.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoAnnotationVisitor.java Mon Apr 28 21:42:54 2014
@@ -41,7 +41,7 @@ public class MojoAnnotationVisitor
MojoAnnotationVisitor( Logger logger, String annotationClassName )
{
- super(Opcodes.ASM4);
+ super( Opcodes.ASM4 );
this.logger = logger;
this.annotationClassName = annotationClassName;
}
@@ -54,24 +54,20 @@ public class MojoAnnotationVisitor
public void visit( String name, Object value )
{
annotationValues.put( name, value );
- logger.debug( "MojoAnnotationVisitor#visit:" + name + ":" + value );
}
public void visitEnum( String name, String desc, String value )
{
annotationValues.put( name, value );
- logger.debug( "MojoAnnotationVisitor#visitEnum:" + name + ":" + desc + ":" + value );
}
public AnnotationVisitor visitAnnotation( String name, String desc )
{
- logger.debug( "MojoAnnotationVisitor#visitAnnotation:" + name + ":" + desc );
return new MojoAnnotationVisitor( logger, this.annotationClassName );
}
public AnnotationVisitor visitArray( String s )
{
- logger.debug( "MojoAnnotationVisitor#visitArray" );
return new MojoAnnotationVisitor( logger, this.annotationClassName );
}
Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoClassVisitor.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoClassVisitor.java?rev=1590814&r1=1590813&r2=1590814&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoClassVisitor.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoClassVisitor.java Mon Apr 28 21:42:54 2014
@@ -53,7 +53,7 @@ public class MojoClassVisitor
public MojoClassVisitor( Logger logger )
{
- super(Opcodes.ASM4);
+ super( Opcodes.ASM4 );
this.logger = logger;
}
Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoFieldVisitor.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoFieldVisitor.java?rev=1590814&r1=1590813&r2=1590814&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoFieldVisitor.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/scanner/visitors/MojoFieldVisitor.java Mon Apr 28 21:42:54 2014
@@ -44,7 +44,7 @@ public class MojoFieldVisitor
MojoFieldVisitor( Logger logger, String fieldName, String className )
{
- super(Opcodes.ASM4);
+ super( Opcodes.ASM4 );
this.logger = logger;
this.fieldName = fieldName;
this.className = className;
@@ -62,7 +62,6 @@ public class MojoFieldVisitor
public AnnotationVisitor visitAnnotation( String desc, boolean visible )
{
- logger.debug( "MojoFieldVisitor#visitAnnotation:" + desc );
String annotationClassName = Type.getType( desc ).getClassName();
if ( !MojoAnnotationsScanner.FIELD_LEVEL_ANNOTATIONS.contains( annotationClassName ) )
{