You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by MJJoyce <gi...@git.apache.org> on 2014/03/26 21:05:47 UTC

[GitHub] climate pull request: CLIMATE-382 - Fix UI backend content type is...

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/3

    CLIMATE-382 - Fix UI backend content type issues

    - Stop parsing JSON with ast.literal_eval in tests. Replace with the more
      correct json.loads.
    - json.dumps is no longer called on all output JSON. When returning
      plain JSON this was causing the content type to be incorrectly set as
      text. Now json.dumps is only called when returning a JSONP response so
      we have the dictionary properly serialized. Bottle handles
      automatically setting the content type when returning a dictionary, so
      we don't need to manually set the content-type.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate CLIMATE-382

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit c1af36252894ac9d54a7237e65d62beafc7de659
Author: Michael Joyce <jo...@apache.org>
Date:   2014-03-21T01:08:47Z

    CLIMATE-382 - Fix LFME content type issues
    
    - Stop parsing JSON with ast.literal_eval in tests. Replace with the more
      correct json.loads.
    - json.dumps is no longer called on all output JSON. When returning
      plain JSON this was causing the content type to be incorrectly set as
      text. Now json.dumps is only called when returning a JSONP response so
      we have the dictionary properly serialized. Bottle handles
      automatically setting the content type when returning a dictionary, so
      we don't need to manually set the content-type.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---