You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2024/02/08 23:32:59 UTC
[PR] [CALCITE-6247] BigQuery FORMAT_DATE function handles incorrectly the %e format specifier [calcite]
mihaibudiu opened a new pull request, #3678:
URL: https://github.com/apache/calcite/pull/3678
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6247] BigQuery FORMAT_DATE function handles incorrectly the %e format specifier [calcite]
Posted by "Anthrino (via GitHub)" <gi...@apache.org>.
Anthrino commented on code in PR #3678:
URL: https://github.com/apache/calcite/pull/3678#discussion_r1483769028
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -81,6 +81,13 @@ public enum FormatElementEnum implements FormatElement {
sb.append(work.eeeFormat.format(date));
}
},
+ E("d", "The day of the month as a decimal number (01-31) left-padded with space") {
Review Comment:
Hi @mihaibudiu, all changes looks good to me.
We can replace `(01-31)` in the comment to `(1-31)`, and maybe mention "single digits left-padded with space" to avoid confusion and align with BQ docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6247] BigQuery FORMAT_DATE function handles incorrectly the %e format specifier [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3678:
URL: https://github.com/apache/calcite/pull/3678#issuecomment-1935260458
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3678) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3678&resolved=false&inNewCodePeriod=true)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3678&resolved=false&inNewCodePeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3678&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3678&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3678)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6247] BigQuery FORMAT_DATE function handles incorrectly the %e format specifier [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #3678:
URL: https://github.com/apache/calcite/pull/3678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6247] BigQuery FORMAT_DATE function handles incorrectly the %e format specifier [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3678:
URL: https://github.com/apache/calcite/pull/3678#issuecomment-1935121249
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3678) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3678&resolved=false&inNewCodePeriod=true)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3678&resolved=false&inNewCodePeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3678&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3678&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3678)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org