You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2015/06/05 13:01:16 UTC

svn commit: r1683709 - /qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java

Author: orudyy
Date: Fri Jun  5 11:01:16 2015
New Revision: 1683709

URL: http://svn.apache.org/r1683709
Log:
QPID-6567: Add intrinsic lock synchronization into StartupAppender#append

Modified:
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java?rev=1683709&r1=1683708&r2=1683709&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/logging/StartupAppender.java Fri Jun  5 11:01:16 2015
@@ -36,10 +36,9 @@ import org.apache.qpid.server.configurat
 
 public class StartupAppender  extends AppenderBase<ILoggingEvent>
 {
-    private List<ILoggingEvent> _list = new ArrayList<>();
+    private List<ILoggingEvent> _accumulatedLoggingEvents = new ArrayList<>();
     private Level _consoleAppenderAcceptLogLevel = Level.INFO;
 
-
     public StartupAppender()
     {
         super();
@@ -51,14 +50,15 @@ public class StartupAppender  extends Ap
         }
     }
 
-    protected void append(ILoggingEvent e)
+    @Override
+    protected synchronized void append(ILoggingEvent e)
     {
-        _list.add(e);
+        _accumulatedLoggingEvents.add(e);
     }
 
     public synchronized void replayAccumulatedEvents(Appender<ILoggingEvent> appender)
     {
-        for (ILoggingEvent event: _list)
+        for (ILoggingEvent event: _accumulatedLoggingEvents)
         {
             appender.doAppend(event);
         }
@@ -97,7 +97,7 @@ public class StartupAppender  extends Ap
         super.stop();
         synchronized (this)
         {
-            _list.clear();
+            _accumulatedLoggingEvents.clear();
         }
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org