You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by gardellajuanpablo <gi...@git.apache.org> on 2018/04/12 00:03:00 UTC
[GitHub] nifi pull request #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XC...
GitHub user gardellajuanpablo opened a pull request:
https://github.com/apache/nifi/pull/2629
NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is…
… closed
Discovered on Phoenix Database by using QueryDatabaseTable processor. The fix consists
on applying Matt Burgess' suggestion:
"I think we'd need a try/catch around the next() only to see if the result set is closed,
and an inner try/catch around everything else, to catch other errors not related to
this behavior. "
The solution was verified against Phoenix DB. Also added unit tests to cover the
change.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gardellajuanpablo/nifi NIFI-5070
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2629.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2629
----
commit 859616f300986e62bd613cb3fd8cc05d823952c6
Author: Gardella Juan Pablo <ga...@...>
Date: 2018-04-11T23:53:17Z
NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): ResultSet is closed
Discovered on Phoenix Database by using QueryDatabaseTable processor. The fix consists
on applying Matt Burgess' suggestion:
"I think we'd need a try/catch around the next() only to see if the result set is closed,
and an inner try/catch around everything else, to catch other errors not related to
this behavior. "
The solution was verified against Phoenix DB. Also added unit tests to cover the
change.
----
---
[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...
Posted by gardellajuanpablo <gi...@git.apache.org>.
Github user gardellajuanpablo commented on the issue:
https://github.com/apache/nifi/pull/2629
Hi @patricker,
Regarding:
"Also, this seems to specifically be for Phoenix. With the fix as is, I don't know if it's possible to tell the difference between a database going offline for maintenance mid resultset read and a Phoenix end of resulset closure."
I discovered by using Phoenix, but Phoenix follows the JDBC spec. As I implemented, if there is a DB error the original exception is propagated to the caller. Please refer to the change I've did, if I'm missing something, please let me know.
---
[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2629
The database error only propagates if `isClosed` returns false; I was thinking that it might be possible to have a connection close before all results are read. The documentation isn't clear on this point, it just says isClosed will be true either when specifically closed, or if automatically closed... which basically leaves it open to any circumstance a driver might want to cover...
---
[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...
Posted by gardellajuanpablo <gi...@git.apache.org>.
Github user gardellajuanpablo commented on the issue:
https://github.com/apache/nifi/pull/2629
@zenfenan fixed checkstyle violations. Thanks
---
[GitHub] nifi issue #2629: NIFI-5070 Fix java.sql.SQLException: ERROR 1101 (XCL01): R...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2629
I like the unit tests, but what about moving your check?
If you created a `catch` block at the end of the existing `try` block in `convertToAvroStream` it would probably simplify the flow a lot. Keep the same `isClosed` check... maybe?
Also, this seems to specifically be for Phoenix. With the fix as is, I don't know if it's possible to tell the difference between a database going offline for maintenance mid resultset read and a Phoenix end of resulset closure.
Could we check the Exception Message for the specific Phoenix error code so we don't block visibility to legitimate early connection closure errors?
---