You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2023/01/09 03:11:00 UTC

[jira] [Resolved] (ORC-1347) use make_unique and make_shared when creating unique_ptr and shared_ptr

     [ https://issues.apache.org/jira/browse/ORC-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved ORC-1347.
--------------------------------
    Fix Version/s: 1.9.0
                       (was: master)
       Resolution: Fixed

Issue resolved by pull request 1357
[https://github.com/apache/orc/pull/1357]

> use make_unique and make_shared when creating unique_ptr and shared_ptr
> -----------------------------------------------------------------------
>
>                 Key: ORC-1347
>                 URL: https://issues.apache.org/jira/browse/ORC-1347
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: master
>            Reporter: Junwang Zhao
>            Assignee: Junwang Zhao
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> We have already switched to C++17, so make_unique should be there, use make_unique
> and make_shared will make the code more neat and maintainable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)