You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/09/25 03:31:13 UTC

[GitHub] [dubbo] codecov-io commented on issue #4730: Merge exceptions, remove redundant interface implementations

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=h1) Report
> Merging [#4730](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/600f0db5fa3516fcee5e9b70e4bf100e49741840?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `77.5%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/4730/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #4730      +/-   ##
============================================
- Coverage      64.1%   64.04%   -0.06%     
- Complexity      453      456       +3     
============================================
  Files           769      769              
  Lines         33263    33264       +1     
  Branches       5250     5251       +1     
============================================
- Hits          21324    21305      -19     
- Misses         9504     9521      +17     
- Partials       2435     2438       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtUHJvdG9jb2wuamF2YQ==) | `82.35% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ubbo/rpc/protocol/nativethrift/ThriftProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1uYXRpdmUtdGhyaWZ0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvbmF0aXZldGhyaWZ0L1RocmlmdFByb3RvY29sLmphdmE=) | `74.69% <77.5%> (+3.96%)` | `10 <4> (+2)` | :arrow_up: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `61.4% <0%> (-7.02%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==) | `68.21% <0%> (-3.11%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.54% <0%> (-3.07%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `72.83% <0%> (-1.74%)` | `0% <0%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/dubbo/pull/4730/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=footer). Last update [600f0db...eb43334](https://codecov.io/gh/apache/dubbo/pull/4730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/4730 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org