You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/02/16 10:58:40 UTC
[PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
dongjoon-hyun opened a new pull request, #45138:
URL: https://github.com/apache/spark/pull/45138
### What changes were proposed in this pull request?
This PR aims to add `derby-provided` profile.
### Why are the changes needed?
To help the users add their derby binary easily.
### Does this PR introduce _any_ user-facing change?
No, this is a new additional profile.
### How was this patch tested?
Manual.
```
$ dev/make-distribution.sh -Phive,derby-provided
$ ls dist/jars/derby*
zsh: no matches found: dist/jars/derby*
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45138:
URL: https://github.com/apache/spark/pull/45138#issuecomment-1949304069
Thank you, @xinrong-meng .
We can skip this because we only document `hadoop-provided` so far.
```
$ git grep '\-provided' assembly
assembly/pom.xml: <id>hadoop-provided</id>
assembly/pom.xml: <id>hive-provided</id>
assembly/pom.xml: <id>orc-provided</id>
assembly/pom.xml: <id>parquet-provided</id>
```
```
$ git grep hadoop-provided docs/
docs/building-spark.md:The `hadoop-provided` profile builds the assembly without including Hadoop-ecosystem projects,
docs/index.md:[by augmenting Spark's classpath](hadoop-provided.html).
$ git grep hive-provided docs/
$ git grep orc-provided docs/
$ git grep parquet-provided docs/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45138:
URL: https://github.com/apache/spark/pull/45138#issuecomment-1949306231
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45138: [SPARK-47075][BUILD] Add `derby-provided` profile
URL: https://github.com/apache/spark/pull/45138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #45138:
URL: https://github.com/apache/spark/pull/45138#issuecomment-1949299783
LGTM, thanks @dongjoon-hyun . Out of curiosity, do we have documentation on those build profiles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47075][BUILD] Add `derby-provided` profile [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #45138:
URL: https://github.com/apache/spark/pull/45138#issuecomment-1949325532
Good to know, thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org