You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2007/08/21 10:02:58 UTC

svn commit: r568000 - in /jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http: ParseException.java message/BasicLineParser.java message/HeaderValueParser.java message/LineParser.java

Author: olegk
Date: Tue Aug 21 01:02:55 2007
New Revision: 568000

URL: http://svn.apache.org/viewvc?rev=568000&view=rev
Log:
* Removed 1.4 Exception constructor
* Removed unused imports
* Removed superfluous public and final from interface declarations 

Modified:
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ParseException.java
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicLineParser.java
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/HeaderValueParser.java
    jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/LineParser.java

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ParseException.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ParseException.java?rev=568000&r1=567999&r2=568000&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ParseException.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/ParseException.java Tue Aug 21 01:02:55 2007
@@ -62,13 +62,4 @@
         super(message);
     }
 
-    /**
-     * Creates a {@link ParseException} with a detail message and root cause.
-     * 
-     * @param message the exception detail message, or <code>null</code>
-     * @param cause the root cause of this exception, or <tt>null</tt>
-     */
-    public ParseException(String message, Throwable cause) {
-        super(message, cause);
-    }
 }

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicLineParser.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicLineParser.java?rev=568000&r1=567999&r2=568000&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicLineParser.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicLineParser.java Tue Aug 21 01:02:55 2007
@@ -31,8 +31,6 @@
 
 package org.apache.http.message;
 
-
-import org.apache.http.HttpStatus;
 import org.apache.http.HttpVersion;
 import org.apache.http.ParseException;
 import org.apache.http.ProtocolException;

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/HeaderValueParser.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/HeaderValueParser.java?rev=568000&r1=567999&r2=568000&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/HeaderValueParser.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/HeaderValueParser.java Tue Aug 21 01:02:55 2007
@@ -86,9 +86,9 @@
      *
      * @throws ParseException        in case of a parse error
      */
-    public HeaderElement[] parseElements(final CharArrayBuffer buffer,
-                                         final int indexFrom,
-                                         final int indexTo)
+    HeaderElement[] parseElements(CharArrayBuffer buffer,
+                                  int indexFrom,
+                                  int indexTo)
         throws ParseException
         ;
 
@@ -173,9 +173,9 @@
      *
      * @throws ParseException        in case of a parse error
      */
-    public NameValuePair[] parseParameters(final CharArrayBuffer buffer,
-                                           final int indexFrom,
-                                           final int indexTo)
+    NameValuePair[] parseParameters(CharArrayBuffer buffer,
+                                    int indexFrom,
+                                    int indexTo)
         throws ParseException
         ;
 

Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/LineParser.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/LineParser.java?rev=568000&r1=567999&r2=568000&view=diff
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/LineParser.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/LineParser.java Tue Aug 21 01:02:55 2007
@@ -68,9 +68,9 @@
      *
      * @throws ProtocolException        in case of a parse error
      */
-    public HttpVersion parseProtocolVersion(final CharArrayBuffer buffer,
-                                            final int indexFrom,
-                                            final int indexTo) 
+    HttpVersion parseProtocolVersion(CharArrayBuffer buffer,
+                                     int indexFrom,
+                                     int indexTo) 
         throws ProtocolException
         ;
 
@@ -84,9 +84,9 @@
      *
      * @throws ProtocolException        in case of a parse error
      */
-    public RequestLine parseRequestLine(final CharArrayBuffer buffer,
-                                        final int indexFrom,
-                                        final int indexTo)
+    RequestLine parseRequestLine(CharArrayBuffer buffer,
+                                 int indexFrom,
+                                 int indexTo)
         throws ProtocolException
         ;
 
@@ -100,9 +100,9 @@
      *
      * @throws ProtocolException        in case of a parse error
      */
-    public StatusLine parseStatusLine(final CharArrayBuffer buffer,
-                                      final int indexFrom,
-                                      final int indexTo) 
+    StatusLine parseStatusLine(CharArrayBuffer buffer,
+                               int indexFrom,
+                               int indexTo) 
         throws ProtocolException
         ;
 
@@ -122,7 +122,7 @@
      *
      * @throws ProtocolException        in case of a parse error
      */
-    public Header parseHeader(CharArrayBuffer buffer)
+    Header parseHeader(CharArrayBuffer buffer)
         throws ProtocolException
         ;
 



Re: svn commit: r568000

Posted by Roland Weber <os...@dubioso.net>.
olegk@apache.org wrote:

> * Removed 1.4 Exception constructor

Aaargh, sorry. I copied and pasted from ProtocolException.
Constructors of standard Java exceptions are inconsistent.

Thanks for cleaning up.

cheers,
  Roland


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org