You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Chris Bowditch <bo...@hotmail.com> on 2004/09/01 11:40:16 UTC

[Fwd: DO NOT REPLY [Bug 29124] - New line breaking algorithm]

> ------- Additional Comments From spepping@leverkruid.nl  2004-08-31 18:44 -------
> Thanks for the new patch. I could apply it without problems, and
> testing it goes well.
> 
> You mention that you have not implemented the Knuth algorithm for
> ContentLM. Would it be difficult to do that?
> 
> FOP team,
> 
> If I would apply this patch, we would get the following regressions:
> 
> - ContentLM does not show its content. A leader with
>   leader-pattern="use-content" results in a blank area of the right
>   size.

Doesnt sound like it will be difficult to fix after the patch is applied.

> 
> - When for an exceptionally difficult paragraph no set of breaking
>   points can be found, the whole paragraph is printed on a single
>   line. This occurs, for example, when in a narrow typesetting width
>   only a single word or a part of it fits in a line.

I would think that strange effects like this are possible today. Can you see 
what the output would look like in such a scenario with the current code?

> 
> I am working towards applying this patch despite these
> regressions, for these reasons:
> 
> - This patch is a good piece of work, and a step forward for FOP's
>   layout.

Agreed.

> 
> - It becomes increasingly hard to maintain this patch outside of CVS.

I know how you feel. I found it hard work before when I examined Luca's 
earlier Knuth patch.

Chris





Re: [Bug 29124] - New line breaking algorithm

Posted by Simon Pepping <sp...@leverkruid.nl>.
On Wed, Sep 01, 2004 at 10:40:16AM +0100, Chris Bowditch wrote:
> >------- Additional Comments From spepping@leverkruid.nl  2004-08-31 18:44 
> >-------
> >FOP team,
> >
> >If I would apply this patch, we would get the following regressions:
> >
> >- When for an exceptionally difficult paragraph no set of breaking
> >  points can be found, the whole paragraph is printed on a single
> >  line. This occurs, for example, when in a narrow typesetting width
> >  only a single word or a part of it fits in a line.
> 
> I would think that strange effects like this are possible today. Can you 
> see what the output would look like in such a scenario with the current 
> code?

The current code breaks the paragraphs into lines. It makes short
lines.

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl