[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6351: GEODE-7309: uplift lucene to 7.1.0

[GitBox <gi...@apache.org>]

rhoughton-pivot commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r617693515



##########
File path: geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated.java
##########
@@ -31,6 +32,7 @@
 public class RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated
     extends LuceneSearchWithRollingUpgradeDUnit {
 
+  @Ignore

Review comment:
       Can you comment on why this test is being ignored, and when or how we will re-write or re-enable it again?

##########
File path: geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
##########
@@ -142,23 +142,17 @@ void executeLuceneQueryWithServerRollOvers(String regionType, String startingVer
 
       server1 = rollServerToCurrentCreateLuceneIndexAndCreateRegion(server1, regionType,
           testingDirs[0], shortcutName, regionName, locatorPorts, reindex);
-      verifyLuceneQueryResultInEachVM(regionName, expectedRegionSize, server1);
       expectedRegionSize += 5;
-      putSerializableObjectAndVerifyLuceneQueryResult(server1, regionName, expectedRegionSize, 5,
-          15, server2, server3);
+      putSerializableObject(server1, regionName, 5, 15);

Review comment:
       My review is mostly for the gradle and pom changes involved in rolling the Lucene dependency version. Seems fine to roll a major-version of our dependency in a minor version of Geode. 
   
   My question here, is why are we not validating the result of this `put` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org