You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/31 16:29:53 UTC

[GitHub] [spark] rdblue commented on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions APIs on DataSourceV2

rdblue commented on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-667214218


   > I think it's still better to have real examples to validate the new API. Can you open a new PR based on this PR, and implement AlterTableAddPartitionCommand as an example?
   
   @stczwd, please hold off on doing this. There is not consensus that adding example implementations is a good idea.
   
   @cloud-fan, if you really think that's a good idea, please bring it to a vote on the dev list.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org