You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/16 10:28:40 UTC

[GitHub] [airflow] ashb commented on a change in pull request #9008: Get connections uri with AWS Secrets Manager backend

ashb commented on a change in pull request #9008:
URL: https://github.com/apache/airflow/pull/9008#discussion_r455686570



##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -60,15 +59,23 @@ class SecretsManagerBackend(BaseSecretsBackend, LoggingMixin):
 
     def __init__(
         self,
-        connections_prefix: str = 'airflow/connections',
-        variables_prefix: str = 'airflow/variables',
-        profile_name: Optional[str] = None,
-        sep: str = "/",
+        connections_prefix=None,

Review comment:
       Why do these need to be None? this controls where in the secrets hierarchy to look at, so should be a required field, no?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org