You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/29 19:07:52 UTC
[GitHub] [pulsar-helm-chart] toneill818 opened a new pull request #140: Add Support for imagePullSecrets
toneill818 opened a new pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140
Fixes #125
### Motivation
The default images in the values.yaml are in docker hub. This PR allows us to provide image pull secrets for the containers which will allow us to get around Docker Hub's rate limiting if the nodes are not logged into Docker Hub.
### Modifications
Added a new template to generate `imagePullSecrets`, and included them in the deployments and statefulsets. This will only add them if they are specified under `images.imagePullSecrets`
### Verifying this change
- [] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
toneill818 commented on pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140#issuecomment-895319326
@michaeljmarshall Are there any other changes I should make?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140#issuecomment-895346230
@toneill818 - did you test this PR with a value in the `.Values.images.imagePullSecrets`? The current tests wouldn't have covered that case, and your initial comment only mentions relying on the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie merged pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140#issuecomment-895410055
@sijie - PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140#discussion_r680216490
##########
File path: charts/pulsar/templates/_helpers.tpl
##########
@@ -84,3 +84,15 @@ Create the match labels.
app: {{ template "pulsar.name" . }}
release: {{ .Release.Name }}
{{- end }}
+
+{{/*
+Create ImagePullSecrets
+*/}}
+{{- define "imagePullSecrets" -}}
Review comment:
This template name is global. Even though this template is generic, I think we should namespace it with the helm chart's name. It could instead be `pulsar.imagePullSecrets`.
Here is a reference to the helm [documentation](https://helm.sh/docs/chart_template_guide/named_templates/#declaring-and-using-templates-with-define-and-template) for this convention:
> As mentioned above, template names are global. As a result of this, if two templates are declared with the same name the last occurrence will be the one that is used. Since templates in subcharts are compiled together with top-level templates, it is best to name your templates with chart specific names. A popular naming convention is to prefix each defined template with the name of the chart: {{ define "mychart.labels" }}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #140: Add Support for imagePullSecrets
Posted by GitBox <gi...@apache.org>.
toneill818 commented on pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140#issuecomment-895408496
@michaeljmarshall Yes, I am currently using my branch with imagePullSecrets populated to work with Docker Hub's rate limits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org