You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by rf...@apache.org on 2007/04/08 08:10:05 UTC
svn commit: r526532 - in /incubator/tuscany/java/sca/modules:
core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/
core/src/main/java/org/apache/tuscany/core/bootstrap/
core/src/main/java/org/apache/tuscany/core/runtime/
core/src/test/java/org/apac...
Author: rfeng
Date: Sat Apr 7 23:10:04 2007
New Revision: 526532
URL: http://svn.apache.org/viewvc?view=rev&rev=526532
Log:
Move ExtensionActivator and ExtensionPointRegistry to core-spi
Added:
incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionActivator.java
- copied, changed from r526531, incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionActivator.java
incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionPointRegistry.java
- copied, changed from r526531, incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistry.java
incubator/tuscany/java/sca/modules/host-embedded/src/test/resources/META-INF/services/org.apache.tuscany.spi.bootstrap.ExtensionActivator
- copied unchanged from r526528, incubator/tuscany/java/sca/modules/host-embedded/src/test/resources/META-INF/services/org.apache.tuscany.core.bootstrap.ExtensionActivator
Removed:
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionActivator.java
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistry.java
incubator/tuscany/java/sca/modules/host-embedded/src/test/resources/META-INF/services/org.apache.tuscany.core.bootstrap.ExtensionActivator
Modified:
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/Bootstrapper.java
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/DefaultBootstrapper.java
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImpl.java
incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/runtime/AbstractRuntime.java
incubator/tuscany/java/sca/modules/core/src/test/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImplTestCase.java
incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/runtime/embedded/SimpleRuntimeImpl.java
incubator/tuscany/java/sca/modules/host-embedded/src/test/java/org/apache/tuscany/container/crud/CRUDExtensionActivator.java
Copied: incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionActivator.java (from r526531, incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionActivator.java)
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionActivator.java?view=diff&rev=526532&p1=incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionActivator.java&r1=526531&p2=incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionActivator.java&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionActivator.java (original)
+++ incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionActivator.java Sat Apr 7 23:10:04 2007
@@ -17,7 +17,7 @@
* under the License.
*/
-package org.apache.tuscany.core.bootstrap;
+package org.apache.tuscany.spi.bootstrap;
/**
Copied: incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionPointRegistry.java (from r526531, incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistry.java)
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionPointRegistry.java?view=diff&rev=526532&p1=incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistry.java&r1=526531&p2=incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionPointRegistry.java&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistry.java (original)
+++ incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/spi/bootstrap/ExtensionPointRegistry.java Sat Apr 7 23:10:04 2007
@@ -17,7 +17,7 @@
* under the License.
*/
-package org.apache.tuscany.core.bootstrap;
+package org.apache.tuscany.spi.bootstrap;
/**
Modified: incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/Bootstrapper.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/Bootstrapper.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/Bootstrapper.java (original)
+++ incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/Bootstrapper.java Sat Apr 7 23:10:04 2007
@@ -20,6 +20,7 @@
import org.apache.tuscany.host.MonitorFactory;
import org.apache.tuscany.services.spi.contribution.ContributionService;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.spi.component.ComponentManager;
import org.apache.tuscany.spi.component.ScopeRegistry;
import org.apache.tuscany.spi.deployer.Deployer;
Modified: incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/DefaultBootstrapper.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/DefaultBootstrapper.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/DefaultBootstrapper.java (original)
+++ incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/DefaultBootstrapper.java Sat Apr 7 23:10:04 2007
@@ -33,6 +33,7 @@
import org.apache.tuscany.core.implementation.composite.CompositeBuilder;
import org.apache.tuscany.host.MonitorFactory;
import org.apache.tuscany.services.spi.contribution.ContributionService;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.spi.builder.BuilderRegistry;
import org.apache.tuscany.spi.component.ComponentManager;
import org.apache.tuscany.spi.component.ScopeContainerMonitor;
Modified: incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImpl.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImpl.java (original)
+++ incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImpl.java Sat Apr 7 23:10:04 2007
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
+
/**
* A registry to hold all the extension points and extensions
*
Modified: incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/runtime/AbstractRuntime.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/runtime/AbstractRuntime.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/runtime/AbstractRuntime.java (original)
+++ incubator/tuscany/java/sca/modules/core/src/main/java/org/apache/tuscany/core/runtime/AbstractRuntime.java Sat Apr 7 23:10:04 2007
@@ -42,8 +42,6 @@
import org.apache.tuscany.assembly.impl.DefaultAssemblyFactory;
import org.apache.tuscany.core.bootstrap.Bootstrapper;
import org.apache.tuscany.core.bootstrap.DefaultBootstrapper;
-import org.apache.tuscany.core.bootstrap.ExtensionActivator;
-import org.apache.tuscany.core.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.core.bootstrap.ExtensionPointRegistryImpl;
import org.apache.tuscany.core.component.ComponentManagerImpl;
import org.apache.tuscany.core.component.SimpleWorkContext;
@@ -59,6 +57,8 @@
import org.apache.tuscany.interfacedef.java.JavaInterface;
import org.apache.tuscany.interfacedef.java.impl.DefaultJavaFactory;
import org.apache.tuscany.services.spi.contribution.ContributionService;
+import org.apache.tuscany.spi.bootstrap.ExtensionActivator;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.spi.component.AtomicComponent;
import org.apache.tuscany.spi.component.Component;
import org.apache.tuscany.spi.component.ComponentManager;
Modified: incubator/tuscany/java/sca/modules/core/src/test/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImplTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core/src/test/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImplTestCase.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/core/src/test/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImplTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/core/src/test/java/org/apache/tuscany/core/bootstrap/ExtensionPointRegistryImplTestCase.java Sat Apr 7 23:10:04 2007
@@ -1,5 +1,7 @@
package org.apache.tuscany.core.bootstrap;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
+
import junit.framework.TestCase;
public class ExtensionPointRegistryImplTestCase extends TestCase {
Modified: incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/runtime/embedded/SimpleRuntimeImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/runtime/embedded/SimpleRuntimeImpl.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/runtime/embedded/SimpleRuntimeImpl.java (original)
+++ incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/runtime/embedded/SimpleRuntimeImpl.java Sat Apr 7 23:10:04 2007
@@ -30,7 +30,6 @@
import org.apache.tuscany.assembly.xml.impl.CompositeDocumentProcessor;
import org.apache.tuscany.assembly.xml.impl.CompositeProcessor;
import org.apache.tuscany.assembly.xml.impl.ConstrainingTypeProcessor;
-import org.apache.tuscany.core.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.core.bootstrap.ExtensionPointRegistryImpl;
import org.apache.tuscany.core.component.SimpleWorkContext;
import org.apache.tuscany.core.runtime.AbstractRuntime;
@@ -53,6 +52,7 @@
import org.apache.tuscany.services.spi.contribution.DefaultURLArtifactProcessorRegistry;
import org.apache.tuscany.services.spi.contribution.StAXArtifactProcessorRegistry;
import org.apache.tuscany.spi.Scope;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.spi.component.AtomicComponent;
import org.apache.tuscany.spi.component.Component;
import org.apache.tuscany.spi.component.SCAObject;
Modified: incubator/tuscany/java/sca/modules/host-embedded/src/test/java/org/apache/tuscany/container/crud/CRUDExtensionActivator.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/test/java/org/apache/tuscany/container/crud/CRUDExtensionActivator.java?view=diff&rev=526532&r1=526531&r2=526532
==============================================================================
--- incubator/tuscany/java/sca/modules/host-embedded/src/test/java/org/apache/tuscany/container/crud/CRUDExtensionActivator.java (original)
+++ incubator/tuscany/java/sca/modules/host-embedded/src/test/java/org/apache/tuscany/container/crud/CRUDExtensionActivator.java Sat Apr 7 23:10:04 2007
@@ -19,9 +19,9 @@
package org.apache.tuscany.container.crud;
-import org.apache.tuscany.core.bootstrap.ExtensionActivator;
-import org.apache.tuscany.core.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.services.spi.contribution.StAXArtifactProcessorRegistry;
+import org.apache.tuscany.spi.bootstrap.ExtensionActivator;
+import org.apache.tuscany.spi.bootstrap.ExtensionPointRegistry;
import org.apache.tuscany.spi.builder.BuilderRegistry;
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org
Re: Tuscany extension mechanism, was: svn commit: r526532
Posted by Raymond Feng <en...@gmail.com>.
Hi,
Please see my comments inline.
Thanks,
Raymond
----- Original Message -----
From: "Jean-Sebastien Delfino" <js...@apache.org>
To: <tu...@ws.apache.org>
Sent: Sunday, April 08, 2007 2:37 PM
Subject: Tuscany extension mechanism, was: svn commit: r526532
> rfeng@apache.org wrote:
>> Author: rfeng
>> Date: Sat Apr 7 23:10:04 2007
>> New Revision: 526532
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=526532
>> Log:
>> Move ExtensionActivator and ExtensionPointRegistry to core-spi
>>
>>
>
> This looks pretty good. I just have a few minor comments.
>
> I think it would make sense to rename ExtensionActivator to something
> else, since it is used to represent a Module more than an Extension, and
> can contribute many Extensions. I would suggest to name this
> RuntimeModule, with the following methods:
I was about to propose a similar change such as ModuleActivator or
ModuleBinder.
>
> The start() method is called when the module starts. This is where you can
> add the Extensions that you contribute to the relevant Extension points.
>
> The stop() method is called when the module stops.
>
> A new Object[] getExtensionPoints() method. The getExtensionPoint() method
> will be called before the start() method and should return the Extension
> points defined by the module. I think we'll need this to determine the set
> of available Extension points and populate your ExtensionPointRegistry
> before passing it to the RuntimeModule.start() methods.
I agree.
>
> Thoughts?
>
> --
> Jean-Sebastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Tuscany extension mechanism, was: svn commit: r526532
Posted by Jean-Sebastien Delfino <js...@apache.org>.
rfeng@apache.org wrote:
> Author: rfeng
> Date: Sat Apr 7 23:10:04 2007
> New Revision: 526532
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=526532
> Log:
> Move ExtensionActivator and ExtensionPointRegistry to core-spi
>
>
This looks pretty good. I just have a few minor comments.
I think it would make sense to rename ExtensionActivator to something
else, since it is used to represent a Module more than an Extension, and
can contribute many Extensions. I would suggest to name this
RuntimeModule, with the following methods:
The start() method is called when the module starts. This is where you
can add the Extensions that you contribute to the relevant Extension points.
The stop() method is called when the module stops.
A new Object[] getExtensionPoints() method. The getExtensionPoint()
method will be called before the start() method and should return the
Extension points defined by the module. I think we'll need this to
determine the set of available Extension points and populate your
ExtensionPointRegistry before passing it to the RuntimeModule.start()
methods.
Thoughts?
--
Jean-Sebastien
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org