You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2017/05/04 15:47:43 UTC

[GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15435#discussion_r114816222
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -1449,6 +1513,107 @@ class BinaryLogisticRegressionSummary private[classification] (
       }
     }
     
    +sealed trait BinaryLogisticRegressionTrainingSummary extends BinaryLogisticRegressionSummary
    +  with LogisticRegressionTrainingSummary
    +
    +/**
    + * :: Experimental ::
    + * Multiclass logistic regression training results.
    + *
    + * @param predictions dataframe output by the model's `transform` method.
    + * @param probabilityCol field in "predictions" which gives the probability of
    + *                       each class as a vector.
    + * @param predictionCol field in "predictions" which gives the prediction for a data instance as a
    + *                      double.
    + * @param labelCol field in "predictions" which gives the true label of each instance.
    + * @param featuresCol field in "predictions" which gives the features of each instance as a vector.
    + * @param objectiveHistory objective function (scaled loss + regularization) at each iteration.
    + */
    +@Experimental
    +@Since("2.2.0")
    --- End diff --
    
    Remove ```Experimental``` and ```Since``` tag for private class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org