[jira] [Created] (HTTPCLIENT-1923) Not properly closing connections in BasicHttpClientConnectionManager

["Aleksei (JIRA)" <ji...@apache.org>]

Aleksei created HTTPCLIENT-1923:
-----------------------------------

             Summary: Not properly closing connections in BasicHttpClientConnectionManager
                 Key: HTTPCLIENT-1923
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1923
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient (classic)
    Affects Versions: 4.5.5
            Reporter: Aleksei


Seems we are hitting something similiar to the HTTPCLIENT-1655 issue, where established connections were not properly closed (client sends Reset instead of FIN+ACK)

We are using

BasicHttpClientConnectionManager (4.5.5 httpclient version)

and when we are calling client.close(), we see packet with Reset flag enabled in tcpdump

 

Looks like here: [https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java#L378]

must be closeConnection()

[https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java#L209]

instead of shutdownConnection

 

This issue is not present if we are using PoolingHttpClientConnectionManager

(in shutdown() there are pool.shutdown:

[https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java#L410]

where for each entry runs: entry.close(){color:#cc7832} -> this{color}.closeConnection(){color:#cc7832};{color}) - we see normal connection close (FIN+ACK)

 

What do you think about it?

Thank you



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org