You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2016/04/20 16:07:45 UTC
[GitHub] spark pull request: [Minor] [ML] [PySpark] All params should use T...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/12529
[Minor] [ML] [PySpark] All params should use TypeConverter
## What changes were proposed in this pull request?
Find the omissive ```Param``` that should pass the ```TypeConverter``` argument and fix them.
After this PR, all params in pyspark/ml/ use ```TypeConverter```.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark typeConverter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12529
----
commit 90f0f749a5431fb8310a59031069e772cb911a11
Author: Yanbo Liang <yb...@gmail.com>
Date: 2016-04-20T13:57:48Z
All params should use TypeConverter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212580649
@yanboliang Thanks for the PR, LGTM (though I agree with Holden's title nit).
I'll merge this with master now regardless
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212579629
I'm fine with removing expectedType. I brought this up here [https://github.com/apache/spark/pull/12480], but that comment will probably be buried now. I'll create a JIRA: [https://issues.apache.org/jira/browse/SPARK-14768]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212446388
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] All params should use T...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212442049
**[Test build #56359 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56359/consoleFull)** for PR 12529 at commit [`90f0f74`](https://github.com/apache/spark/commit/90f0f749a5431fb8310a59031069e772cb911a11).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212446392
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56359/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212574884
Minor nit: Maybe s/omissive/missing/ for clarity while reading the title?
If all of our Params use type converter, maybe we should remove the default param of none and expected type for 2.0 - the docs mention keeping expected type until 2.1 but that seems maybe a bit longer than necessary if we've completely switched all of our internal types over and while the Params API is technically public I think requiring an explicit type converter specified would be a reasonable change for the 2.0 time frame. Just a thought, what do @sethah & @jkbradley think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] Fix omissive params whi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12529
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] [ML] [PySpark] All params should use T...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12529#issuecomment-212446157
**[Test build #56359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56359/consoleFull)** for PR 12529 at commit [`90f0f74`](https://github.com/apache/spark/commit/90f0f749a5431fb8310a59031069e772cb911a11).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org