You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "bszabo97 (via GitHub)" <gi...@apache.org> on 2023/01/24 09:47:19 UTC
[GitHub] [solr] bszabo97 opened a new pull request, #1311: SOLR-16632: Add core name to periodic delete related log messages
bszabo97 opened a new pull request, #1311:
URL: https://github.com/apache/solr/pull/1311
https://issues.apache.org/jira/browse/SOLR-16632
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
When expired documents are deleted periodically from the index we have a log message about the [start](https://github.com/apache/solr/blob/0725a9ba853c1a0caacd7c2c037cbe11bd4b4b39/solr/core/src/java/org/apache/solr/update/processor/DocExpirationUpdateProcessorFactory.java#L384) and the [end](https://github.com/apache/solr/blob/0725a9ba853c1a0caacd7c2c037cbe11bd4b4b39/solr/core/src/java/org/apache/solr/update/processor/DocExpirationUpdateProcessorFactory.java#L419) of this process.
In cases where we have multiple collections with TTL enabled it can be misleading that these messages do not contain the name of the actual collection/core on which the periodic delete is executed. The name of the core can be easily added to the log message.
# Solution
I have added `core.getName()` as a parameter to the above mentioned log lines.
# Tests
I have manually tested that the core name appears in the log messages after my modification.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] asalamon74 closed pull request #1311: SOLR-16632: Add core name to periodic delete related log messages
Posted by "asalamon74 (via GitHub)" <gi...@apache.org>.
asalamon74 closed pull request #1311: SOLR-16632: Add core name to periodic delete related log messages
URL: https://github.com/apache/solr/pull/1311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] asalamon74 commented on pull request #1311: SOLR-16632: Add core name to periodic delete related log messages
Posted by "asalamon74 (via GitHub)" <gi...@apache.org>.
asalamon74 commented on PR #1311:
URL: https://github.com/apache/solr/pull/1311#issuecomment-1411795175
Thanks @bszabo97 committed the change to `main` and `branch_9x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org