You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/01/11 18:50:13 UTC

[jira] [Commented] (TAP5-2049) Tapestry should provide locking semantics for attributes stored in the session, to prevent multiple simultaneous requests (due to Ajax) from conflicting

    [ https://issues.apache.org/jira/browse/TAP5-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551321#comment-13551321 ] 

Hudson commented on TAP5-2049:
------------------------------

Integrated in tapestry-trunk-freestyle #1001 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1001/])
    TAP5-2049: Use a lock when reading/updating HttpSession attributes (Revision bebe2d1417fcfa0b32bd8aa8abd246b3e0c1504c)

     Result = SUCCESS
hlship : 
Files : 
* tapestry-core/src/test/java/org/apache/tapestry5/internal/services/SessionImplTest.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ClusteredSessionImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactoryImpl.java
* tapestry-core/src/test/java/org/apache/tapestry5/internal/services/RequestImplTest.java

                
> Tapestry should provide locking semantics for attributes stored in the session, to prevent multiple simultaneous requests (due to Ajax) from conflicting
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2049
>                 URL: https://issues.apache.org/jira/browse/TAP5-2049
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: session, thread-safety
>             Fix For: 5.4
>
>
> Currently, multiple threads may be processing requests, due to Ajax.  If they all access state stored in the HttpSession, the rsult can be invalid.
> Tapestry should maintain a lock object inside the session, and automatically acquire a read lock the first time a request thread reads values from the session, and upgrade to a write lock when writing values to the session.
> The lock can be released at the end of the request.
> A reentrant read/write lock may be insufficient, as values inside the session are mutable; it is possible that the lock should be exclusive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira