You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/14 11:28:33 UTC
[jira] [Commented] (BEAM-36) TimestampedValueInMultipleWindows
should use a more compact set representation
[ https://issues.apache.org/jira/browse/BEAM-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193064#comment-15193064 ]
ASF GitHub Bot commented on BEAM-36:
------------------------------------
GitHub user yssharma opened a pull request:
https://github.com/apache/incubator-beam/pull/43
BEAM-36 : TimestampedValueInMultipleWindows changes LinkedHashSet to …
Minor fix for TimestampedValueInMultipleWindows. Changed LinkedHashSet to HashSet.
Checked build with test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yssharma/incubator-beam dev/beam-36
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 7fa69279426fae9381d91eb4406ab34e247d78a4
Author: Yash Sharma <ys...@atlassian.com>
Date: 2016-03-14T10:28:15Z
BEAM-36 : TimestampedValueInMultipleWindows changes LinkedHashSet to HashSet
----
> TimestampedValueInMultipleWindows should use a more compact set representation
> ------------------------------------------------------------------------------
>
> Key: BEAM-36
> URL: https://issues.apache.org/jira/browse/BEAM-36
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Trivial
> Labels: Windowing
>
> Today TimestampedValueInMultipleWindows converts its collection of windows to a LinkedHashSet for comparisons and hashing. Since it is an immutable set, more compact representations are available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)