You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Piyush Goyal (JIRA)" <ji...@apache.org> on 2019/05/30 12:44:00 UTC
[jira] [Updated] (FLINK-12681) Provide an implementation of a
thread-safe counter
[ https://issues.apache.org/jira/browse/FLINK-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piyush Goyal updated FLINK-12681:
---------------------------------
Description:
While adding metrics to Elasticsearch connector, we noticed that the SimpleCounter which seems like the main implementation of Counter interface is not thread-safe. It makes it tricky/expensive to use it in a multi-threaded context.
[~SleePy] mentioned that SimpleCounter is being used in some performance-sensitive code paths, so instead of changing it directly, we can provide a new thread-safe implementation of Counter.
was:
While adding metrics to Elasticsearch connector, we noticed that the SimpleCounter which seems like the main implementation of Counter interface is not thread-safe. It makes it tricky/expensive to use it in a multi-threaded context.
It should be a very simple change to make it thread-safe, and the performance benefit (if any) of keeping it thread-unsafe doesn't seem worth the extra care to use it in a multithreaded context. What do you think ?
Summary: Provide an implementation of a thread-safe counter (was: Make SimpleCounter thread-safe.)
> Provide an implementation of a thread-safe counter
> --------------------------------------------------
>
> Key: FLINK-12681
> URL: https://issues.apache.org/jira/browse/FLINK-12681
> Project: Flink
> Issue Type: Improvement
> Reporter: Piyush Goyal
> Priority: Major
>
> While adding metrics to Elasticsearch connector, we noticed that the SimpleCounter which seems like the main implementation of Counter interface is not thread-safe. It makes it tricky/expensive to use it in a multi-threaded context.
> [~SleePy] mentioned that SimpleCounter is being used in some performance-sensitive code paths, so instead of changing it directly, we can provide a new thread-safe implementation of Counter.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)