You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "Alexander Shaklein (Jira)" <ji...@apache.org> on 2020/07/07 18:01:00 UTC

[jira] [Created] (FELIX-6298) ipojo ServiceRegistry concurrency

Alexander Shaklein created FELIX-6298:
-----------------------------------------

             Summary: ipojo ServiceRegistry concurrency
                 Key: FELIX-6298
                 URL: https://issues.apache.org/jira/browse/FELIX-6298
             Project: Felix
          Issue Type: Bug
            Reporter: Alexander Shaklein


Hello.

During source code analyzing i've found some issues.

For example class org.apache.felix.ipojo.context.ServiceRegistry:
{code:java}
synchronized (m_regs) {            
   ServiceRegistrationImpl reg = new ServiceRegistrationImpl(this, instance, new String[] { clazz }, new Long(m_serviceId++), svcObj, dict); 
   m_regs.add(reg);            
   fireServiceChanged(new ServiceEvent(ServiceEvent.REGISTERED, reg.getReference()));            
   return reg;        
}
{code}
Is not good cause:
 * may result deadlock
 * too complex code in synchronized

So the question is - should i contribute some fixes in PR. Are you interested?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)