You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "bschuchardt (GitHub)" <gi...@apache.org> on 2019/02/06 21:46:49 UTC

[GitHub] [geode] bschuchardt opened pull request #3167: GEODE-6369 Cache-creation failure after a successful auto-reconnect causes subsequent NPE


If an error occurs while rebuilding the cache on auto-reconnect we can't
continue and should throw an exception to any thread waiting for the
reconnect to complete.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3167 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #3167: GEODE-6369 Cache-creation failure after a successful auto-reconnect causes subsequent NPE

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/3167 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on issue #3167: GEODE-6369 Cache-creation failure after a successful auto-reconnect causes subsequent NPE

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
closing this PR as it seems to be the wrong approach.  If cluster configuration can't be fetched, for instance, we should try again instead of giving up because the cluster configuration service can take a while to reboot after a Locator comes on line.

[ Full content available at: https://github.com/apache/geode/pull/3167 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org