You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/12 13:29:07 UTC
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3520: stm32h7: Initialize CSI and HSI48 clocks as needed based on enabled peripherals
davids5 commented on a change in pull request #3520:
URL: https://github.com/apache/incubator-nuttx/pull/3520#discussion_r611628340
##########
File path: arch/arm/src/stm32h7/Kconfig
##########
@@ -493,12 +501,14 @@ config STM32H7_OTGFS
bool "OTG FS"
default n
select USBHOST_HAVE_ASYNCH if USBHOST
+ select STM32H7_HSI48
Review comment:
I am not sure that auto selection is the correct thing to do here. Since most of the clock selection in in board.h this should be explicitly set.
Here is the logic: What if I use a PLL source for greater accuracy, now this clock is on burning power and not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org