You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/07/09 09:42:15 UTC
[GitHub] [openwhisk-runtime-go] sciabarracom opened a new pull request #148: Symlink in zips
sciabarracom opened a new pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148
This patch implements the ability to zip and unzip symlinks, essential feature to use virtualenvs like those in Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on a change in pull request #148: Symlink in zips
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148#discussion_r667103183
##########
File path: openwhisk/zip_test.go
##########
@@ -54,3 +55,23 @@ func Example_jar() {
// ./action/unzip/exec.jar
// <nil>
}
+
+func Example_venv() {
Review comment:
Indeed, this is a great addition for the venv use cases and quite unfortunate that the go zip packages do not have a built in means to turn this on and have made devs. walk/handle reading/writing of these cases themselves for years apparently.
It makes me wonder if there is a need to review other langs. like Ruby that also have venvs widely adopted using similar mechanisms as python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarra commented on a change in pull request #148: Symlink in zips
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148#discussion_r667329578
##########
File path: openwhisk/zip_test.go
##########
@@ -54,3 +55,23 @@ func Example_jar() {
// ./action/unzip/exec.jar
// <nil>
}
+
+func Example_venv() {
Review comment:
I think the usual way we do the virtualenv embedding does not use symbolic links, but I introduced the ability to generate a virtualenv using the image itself, and this creates symbolic links that refers to what is in the image itself... and zip code choked on it. So I had to fix. The fix is generic we can do the same also for ruby or deno or other actionloop based runtimes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom commented on pull request #148: Symlink in zips
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148#issuecomment-877221316
Yep. Just not familiar with the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on pull request #148: Symlink in zips
Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148#issuecomment-877180087
@sciabarra will you do a release candidate / vote for this when ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom merged pull request #148: Symlink in zips
Posted by GitBox <gi...@apache.org>.
sciabarracom merged pull request #148:
URL: https://github.com/apache/openwhisk-runtime-go/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org