You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/09 17:35:02 UTC
[GitHub] [nifi] mcgilman commented on a change in pull request #3401:
NIFI-6160 NIFI-6170 Apply config error handling convention
mcgilman commented on a change in pull request #3401: NIFI-6160 NIFI-6170 Apply config error handling convention
URL: https://github.com/apache/nifi/pull/3401#discussion_r273619644
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##########
@@ -307,16 +307,7 @@
if (processorRelationships.is(':visible') && processorRelationships.get(0).scrollHeight > Math.round(processorRelationships.innerHeight())) {
processorRelationships.css('border-width', '1px');
}
- }).fail(function (xhr, status, error) {
- if (xhr.status === 400 || xhr.status === 404 || xhr.status === 409) {
- nfDialog.showOkDialog({
- headerText: 'Error',
- dialogContent: nfCommon.escapeHtml(xhr.responseText)
- });
- } else {
- nfErrorHandler.handleAjaxError(xhr, status, error);
- }
- });
+ }).fail(nfErrorHandler.handleAjaxError(xhr, status, error));
Review comment:
The syntax here is not correct. Should just be referencing the `handleAjaxError` function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services