You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/06 18:46:26 UTC

[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory

kwin commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779777041



##########
File path: .gitignore
##########
@@ -3,7 +3,7 @@ target/
 .classpath
 .settings/
 .svn/
-bin/
+/bin/

Review comment:
       a bin folder is included in the test resources as this is part of the layout below maven home! The intent here is to only exclude compiled classes which will only ever end up in the to-level directory /bin (if at all)!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org