You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/19 01:22:43 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #30366: [SPARK-33440][CORE] Use current timestamp with warning log when the issue date for token is not set up properly

HeartSaVioR commented on pull request #30366:
URL: https://github.com/apache/spark/pull/30366#issuecomment-730061628


   > Sorry, but why do you think we don't need a new test? Is it due to the difficulty?
   
   Yes. This PR only brings 30 lines of changes which is enough intuitive to be reviewed easily, whereas adding a new test incurs mocking everything including token and token identifier which is even harder than the original fix.
   
   This is a sort of "broken window" - the complicated logic is already introduced without any unit tests, and we are trying to enforce adding test from scratch and paying off the old debt instead. I'd be appreciated if you can volunteer to pay off the debt on existing code logic, and then I'll craft a test based on that. Otherwise I'd wonder this is something I should do; time is precious, for everyone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org