You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2018/06/08 19:33:21 UTC

[GitHub] nifi-fds pull request #5: add flow_design_styles.css to demo-app index.html

GitHub user scottyaslan opened a pull request:

    https://github.com/apache/nifi-fds/pull/5

    add flow_design_styles.css to demo-app index.html

    Thank you for submitting a contribution to Apache NiFi Flow Design System.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with either NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder?
    - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scottyaslan/nifi-fds NIFI-5283

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-fds/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 300d2d678d065ebad2b61699005759658d265f2d
Author: Scott Aslan <sc...@...>
Date:   2018-06-08T19:32:43Z

    add flow_design_styles.css to demo-app index.html

----


---

[GitHub] nifi-fds pull request #5: add flow_design_styles.css to demo-app index.html

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-fds/pull/5


---