You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Shingo Omura <ev...@gmail.com> on 2013/10/25 22:21:48 UTC
Review Request 14941: Change mesos-ps so that it runs on python2.6 or above.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
src/cli/mesos-ps a6a8e9b
Diff: https://reviews.apache.org/r/14941/diff/
Testing
-------
I tested this manually on my machine.
Thanks,
Shingo Omura
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/#review28064
-----------------------------------------------------------
Ship it!
Thanks Shingo! This is now committed, can you mark this review submitted?
- Ben Mahler
On Nov. 1, 2013, 10:33 p.m., Shingo Omura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14941/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 10:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps a6a8e9b
>
> Diff: https://reviews.apache.org/r/14941/diff/
>
>
> Testing
> -------
>
> I tested this manually on my machine.
>
>
> Thanks,
>
> Shingo Omura
>
>
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 10:33 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
shell flag in Popen has been changed.
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos-ps a6a8e9b
Diff: https://reviews.apache.org/r/14941/diff/
Testing
-------
I tested this manually on my machine.
Thanks,
Shingo Omura
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Du Li <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/#review28046
-----------------------------------------------------------
Ship it!
Ship It!
- Du Li
On Nov. 1, 2013, 10:08 p.m., Shingo Omura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14941/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 10:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps a6a8e9b
>
> Diff: https://reviews.apache.org/r/14941/diff/
>
>
> Testing
> -------
>
> I tested this manually on my machine.
>
>
> Thanks,
>
> Shingo Omura
>
>
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Shingo Omura <ev...@gmail.com>.
> On Nov. 1, 2013, 10:16 p.m., Ben Mahler wrote:
> > src/cli/mesos-ps, line 56
> > <https://reviews.apache.org/r/14941/diff/2/?file=376664#file376664line56>
> >
> > why the change here?
In the last friday's hackathon, I faced some exception from python runtime in Popen constructor.
But now, the True case looks working fine. So, I change it back.
- Shingo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/#review28047
-----------------------------------------------------------
On Nov. 1, 2013, 10:33 p.m., Shingo Omura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14941/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 10:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps a6a8e9b
>
> Diff: https://reviews.apache.org/r/14941/diff/
>
>
> Testing
> -------
>
> I tested this manually on my machine.
>
>
> Thanks,
>
> Shingo Omura
>
>
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Shingo Omura <ev...@gmail.com>.
> On Nov. 1, 2013, 10:16 p.m., Ben Mahler wrote:
> > src/cli/mesos-ps, line 56
> > <https://reviews.apache.org/r/14941/diff/2/?file=376664#file376664line56>
> >
> > why the change here?
>
> Shingo Omura wrote:
> In the last friday's hackathon, I faced some exception from python runtime in Popen constructor.
> But now, the True case looks working fine. So, I change it back.
typo...
> the True case looks working fine.
the False case looks working fine.
- Shingo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/#review28047
-----------------------------------------------------------
On Nov. 1, 2013, 10:33 p.m., Shingo Omura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14941/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 10:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps a6a8e9b
>
> Diff: https://reviews.apache.org/r/14941/diff/
>
>
> Testing
> -------
>
> I tested this manually on my machine.
>
>
> Thanks,
>
> Shingo Omura
>
>
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/#review28047
-----------------------------------------------------------
src/cli/mesos-ps
<https://reviews.apache.org/r/14941/#comment54555>
why the change here?
- Ben Mahler
On Nov. 1, 2013, 10:08 p.m., Shingo Omura wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14941/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 10:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-ps a6a8e9b
>
> Diff: https://reviews.apache.org/r/14941/diff/
>
>
> Testing
> -------
>
> I tested this manually on my machine.
>
>
> Thanks,
>
> Shingo Omura
>
>
Re: Review Request 14941: Change mesos-ps so that it runs on python2.6 or
above.
Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14941/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 10:08 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Uploaded patch is now git formatted.
So, if this got 'Ship It!', some committer can directly apply this patch to his local repo with 'git am'.
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
src/cli/mesos-ps a6a8e9b
Diff: https://reviews.apache.org/r/14941/diff/
Testing
-------
I tested this manually on my machine.
Thanks,
Shingo Omura