You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/08/28 18:27:37 UTC

[GitHub] [dolphinscheduler] reele opened a new pull request #6056: Fix: sub-process and dependent tasks may fall into an endless-loop by recovery from Kill

reele opened a new pull request #6056:
URL: https://github.com/apache/dolphinscheduler/pull/6056


   
   ## Purpose of the pull request
   
   When recovery a stopping instance, sub-process-task's state may be KILL, but the sub-process-instance is already submitted by RECOVER_TOLERANCE_FAULT_PROCESS command,
   the SubProcessTaskExecThread.waitTaskQuit() will return directly, and set task state with sub-process's state (even if the sub-process is running), so the sub-process-task will ended with an unfinished state,
   so the parent thread MasterExecThread will fall into an endless-loop.
   
   
   ## Brief change log
   
   Add a check in getSubmitTaskState:
   if taskInstance is sub-process or dependent node, and the state is KILL, return SUBMITTED_SUCCESS state.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] reele closed pull request #6056: Fix: sub-process and dependent tasks may fall into an endless-loop by recovery from Kill

Posted by GitBox <gi...@apache.org>.
reele closed pull request #6056:
URL: https://github.com/apache/dolphinscheduler/pull/6056


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org