You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/07 05:34:58 UTC

[GitHub] [ozone] kerneltime opened a new pull request, #3486: HDDS-6836 Always set HSTS Header for Ozone UIs.

kerneltime opened a new pull request, #3486:
URL: https://github.com/apache/ozone/pull/3486

   
   ## What changes were proposed in this pull request?
   
   HSTS headers are a good safety net to protect against high jacking of clients by informing clients to always use HTTPS in the future.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6836
   
   ## How was this patch tested?
   
   ![image](https://user-images.githubusercontent.com/774455/172303587-6349c789-c378-48fe-af67-7a96ca4c645a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on a diff in pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3486:
URL: https://github.com/apache/ozone/pull/3486#discussion_r891914355


##########
hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java:
##########
@@ -117,6 +117,17 @@ default Map<String, String> getPropsWithPrefix(String confPrefix) {
     return configMap;
   }
 
+  default Map<String, String> getPropsMatchingPrefix(String confPrefix) {

Review Comment:
   I think it might be cleanest to rename the 2 similar methods in addition to adding a doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on a diff in pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3486:
URL: https://github.com/apache/ozone/pull/3486#discussion_r891789704


##########
hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java:
##########
@@ -117,6 +117,17 @@ default Map<String, String> getPropsWithPrefix(String confPrefix) {
     return configMap;
   }
 
+  default Map<String, String> getPropsMatchingPrefix(String confPrefix) {

Review Comment:
   nit. we could rename this to `getPropsKeepPrefix`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3486:
URL: https://github.com/apache/ozone/pull/3486#issuecomment-1149456902

   Thank you @smengcl will address the nits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3486:
URL: https://github.com/apache/ozone/pull/3486#issuecomment-1150225229

   Thanks @kerneltime for the patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on a diff in pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3486:
URL: https://github.com/apache/ozone/pull/3486#discussion_r891789704


##########
hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java:
##########
@@ -117,6 +117,17 @@ default Map<String, String> getPropsWithPrefix(String confPrefix) {
     return configMap;
   }
 
+  default Map<String, String> getPropsMatchingPrefix(String confPrefix) {

Review Comment:
   nit. we could rename this to `getPropsKeepPrefix`, or add a comment saying this method keep the prefix in the key of the map, unlike the other similar method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl merged pull request #3486: HDDS-6836. Fix Ozone http header configuration

Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3486:
URL: https://github.com/apache/ozone/pull/3486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org