You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/23 00:21:27 UTC
[kudu-CR] [client-test] removed a couple of unused variables
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5189
Change subject: [client-test] removed a couple of unused variables
......................................................................
[client-test] removed a couple of unused variables
Removed unused variables and did a minor clean-up of the
ClientTest::TestScanMultiTablet test code.
Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
---
M src/kudu/client/client-test.cc
1 file changed, 41 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/5189/1
--
To view, visit http://gerrit.cloudera.org:8080/5189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] removed a couple of unused variables
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client-test] removed a couple of unused variables
......................................................................
[client-test] removed a couple of unused variables
Removed unused variables and did a minor clean-up of the
ClientTest::TestScanMultiTablet test code.
Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Reviewed-on: http://gerrit.cloudera.org:8080/5189
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client-test.cc
1 file changed, 41 insertions(+), 30 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [client-test] removed a couple of unused variables
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client-test] removed a couple of unused variables
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [client-test] removed a couple of unused variables
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5189
to look at the new patch set (#2).
Change subject: [client-test] removed a couple of unused variables
......................................................................
[client-test] removed a couple of unused variables
Removed unused variables and did a minor clean-up of the
ClientTest::TestScanMultiTablet test code.
Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
---
M src/kudu/client/client-test.cc
1 file changed, 41 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/5189/2
--
To view, visit http://gerrit.cloudera.org:8080/5189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [client-test] removed a couple of unused variables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [client-test] removed a couple of unused variables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibecf0368f6739adcb64747f0ad798d4f597088ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No