You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by dawinter <gi...@git.apache.org> on 2019/01/28 17:46:39 UTC
[GitHub] curator pull request #302: Update guava-version to 27.0.1
GitHub user dawinter opened a pull request:
https://github.com/apache/curator/pull/302
Update guava-version to 27.0.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawinter/curator master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit a5bb6ca9ff2c0bd7d67a1335119da8d061248389
Author: dawinter <da...@...>
Date: 2019-01-28T17:45:01Z
Update guava-version to 27.0.1
----
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
This doesn't compile for me - I get a ton of errors. Also, please rename the PR so that to something like: `[CURATOR-502] Update guava-version to 27.0.1`
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
Not at this time. It would be pretty disruptive and there hasn't been a call for it. But, if someone proposes something it will definitely be considered.
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
TBH - this PR is not needed. But, we keep getting requests for it so I'm OK with making the change. But, it's not trivial. Several parts of the codebase need to be updated.
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/curator/pull/302
Ops. Sorry.
I didn't notice.
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
It already is shaded. see here: https://github.com/apache/curator/blob/master/curator-client/pom.xml#L90
---
[GitHub] curator issue #302: [CURATOR-502] Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
This can be closed in favor of #301
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/302
Also see here: https://cwiki.apache.org/confluence/display/CURATOR/TN13
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/curator/pull/302
@Randgalt thanks for the pointer.
Is there any roadmap towards breaking the API and drop Guava classes at least from the public surface of the project?
---
[GitHub] curator issue #302: Update guava-version to 27.0.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/curator/pull/302
@Randgalt as guava has a lot of issues about forward/backward compatibility, did you ever consider to shade it and relocate packages?
---
[GitHub] curator pull request #302: [CURATOR-502] Update guava-version to 27.0.1
Posted by dawinter <gi...@git.apache.org>.
Github user dawinter closed the pull request at:
https://github.com/apache/curator/pull/302
---
[GitHub] curator issue #302: [CURATOR-502] Update guava-version to 27.0.1
Posted by dawinter <gi...@git.apache.org>.
Github user dawinter commented on the issue:
https://github.com/apache/curator/pull/302
Sure, everything that's update the version is ok for me.
---