[GitHub] [hive] lcspinter commented on a diff in pull request #3259: HIVE-26190: Implement create iceberg table with metadata location

[GitBox <gi...@apache.org>]

lcspinter commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r866015481


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -183,6 +183,11 @@ public void preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
     catalogProperties.put(InputFormatConfig.TABLE_SCHEMA, SchemaParser.toJson(schema));
     catalogProperties.put(InputFormatConfig.PARTITION_SPEC, PartitionSpecParser.toJson(spec));
     setCommonHmsTablePropertiesForIceberg(hmsTable);
+
+    hmsTable.getParameters().computeIfPresent(BaseMetastoreTableOperations.METADATA_LOCATION_PROP, (k, v) -> {

Review Comment:
   Yes, you're right. Previously I had some code in the mapping function and I forgot the refactor it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org