[GitHub] [calcite] libenchao commented on a diff in pull request #3120: [CALCITE-5593] Support aliases query in Elasticsearch adapters

["libenchao (via GitHub)" <gi...@apache.org>]

libenchao commented on code in PR #3120:
URL: https://github.com/apache/calcite/pull/3120#discussion_r1141913400


##########
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/ElasticSearchAdapterTest.java:
##########
@@ -189,6 +191,11 @@ private CalciteAssert.AssertThat calciteAssert() {
         .returnsCount(0);
   }
 
+  @Test void testAlias() {
+    calciteAssert()
+        .query("select state, city from elastic.zips_alias");

Review Comment:
   This test seems asserting nothing, hence it won't be run actually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org